[GitHub] [superset] villebro commented on pull request #18205: fix(tests): Remove walrus operator for Python 3.7 compatiblity

[GitBox <gi...@apache.org>]

villebro commented on pull request #18205:
URL: https://github.com/apache/superset/pull/18205#issuecomment-1023693608


   @amitmiran137 @ofekisr as long as `setup.py` lists 3.7 as supported, I can't really see how we can introduce the walrus operator. Having said that, we did raise deprecation of Python 3.7 many months ago on the dev list([link](https://lists.apache.org/thread/v8490vf1horzcy7h5f8oh6xdxh0z2rb2)), so maybe we should just declare 3.7 deprecated now. @ad-m is there a reason why you wish to extend 3.7 support, or are you ok moving to 3.8?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org