You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2016/08/09 05:51:34 UTC
[GitHub] incubator-quickstep pull request #88: Use glog for all sent TMB messages.
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/88
Use glog for all sent TMB messages.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep glog-tmb-msgs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit 48f634c99563583982c94c203fd81bafad99dd4b
Author: Zuyu Zhang <zu...@twitter.com>
Date: 2016-08-09T05:49:59Z
Use glog for all sent TMB messages.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #88: Use glog for all sent TMB messages.
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/88
Hi @zuyu
The changes look fine. I have two comments though:
1. The amount of logging due to these changes will be a lot. If you need the logged information for debugging purposes, it may be worth to use something like DLOG or VLOG(3).
2. If you need to do some analysis on the logs (e.g. counting number of messages sent from a particular client of a specified type), it may be worth to write a utility function which takes the following arguments:
- Sender TMB client ID
- Sender name string (e.g. ForemanSingle, ForemanDistributed, optional field)
- Reciver TMB client ID (some default value if this is a broadcast)
- Receiver name (optional)
- Message type
- Message type string
-
The benefit of such a function is that you will get identical formatting for all the log messages. Therefore performing a grep over the logs will be much easier. Additionally, extending the function to log more information (e.g. message size, send/receive timestamps) will be straightforward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #88: Use glog for all sent TMB messages.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/88
@hbdeshmukh Thank you for your inputs. I'll use `DLOG` for this purpose.
As for the log analysis and the utility function, we could leave for future. For now, I just `glog` outputs for the debug purpose.
Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #88: Use glog for all sent TMB messages.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/88
@hbdeshmukh Could you please take a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #88: Use glog for all sent TMB messages.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---