[GitHub] [drill] cgivre commented on a change in pull request #2310: DRILL-7993: LGTM Code Cleanup-Fixed Javadoc param tags and type conversions

[GitBox <gi...@apache.org>]

cgivre commented on a change in pull request #2310:
URL: https://github.com/apache/drill/pull/2310#discussion_r723692447



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -75,7 +75,7 @@
    * CTOR.
    * @param parentInst parent object instance
    * @param recordsToRead number of records to read
-   * @param columnPrecInfo column precision information
+   * @param bulkReaderState
    * @throws IOException runtime exception in case of processing error
    */

Review comment:
       > This is a comment for lines 94, 290, and 366. There is a typo in the function name: loadPageIfNeeed(). I would like to fix it but do not want to mess up any other files as a result. If I change the name in all 3 cases, is it safe to fix?
   
   You should the `refactor->rename` feature in your IDE.  It will rename all the occurrences of that function name, even those in other files. ;-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org