You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/06/17 07:02:52 UTC
[GitHub] [incubator-pegasus] foreverneverer opened a new pull request, #1007: feat(dup_enhancement#26): update duplicate rpc thrift in go-client
foreverneverer opened a new pull request, #1007:
URL: https://github.com/apache/incubator-pegasus/pull/1007
# Ref-Issue
https://github.com/apache/incubator-pegasus/issues/892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1007: feat(dup_enhancement#26): update duplicate rpc thrift in go-client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1007:
URL: https://github.com/apache/incubator-pegasus/pull/1007#discussion_r899831471
##########
go-client/session/radmin_rpc_types.go:
##########
@@ -15,7 +15,7 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
-*/
+ */
Review Comment:
revert it plz
##########
go-client/session/admin_rpc_types.go:
##########
@@ -15,7 +15,7 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
-*/
+ */
Review Comment:
revert it plz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] codecov-commenter commented on pull request #1007: feat(dup_enhancement#26): update duplicate rpc thrift in go-client
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1007:
URL: https://github.com/apache/incubator-pegasus/pull/1007#issuecomment-1158562552
# [Codecov](https://codecov.io/gh/apache/incubator-pegasus/pull/1007?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@21ab156`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 19e46d6 differs from pull request most recent head 29e5c7d. Consider uploading reports for the commit 29e5c7d to get more accurate results
```diff
@@ Coverage Diff @@
## master #1007 +/- ##
=========================================
Coverage ? 53.31%
=========================================
Files ? 27
Lines ? 2517
Branches ? 0
=========================================
Hits ? 1342
Misses ? 1130
Partials ? 45
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pegasus/pull/1007?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pegasus/pull/1007?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21ab156...29e5c7d](https://codecov.io/gh/apache/incubator-pegasus/pull/1007?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on pull request #1007: feat(dup_enhancement#26): update duplicate rpc thrift in go-client
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on PR #1007:
URL: https://github.com/apache/incubator-pegasus/pull/1007#issuecomment-1158720081
> We should unify the IDL *.thrift files, now they are distributed everywhere, we can do it after rdsn has been merged to Pegasus.
Yeah, I have the same plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer merged pull request #1007: feat(dup_enhancement#26): update duplicate rpc thrift in go-client
Posted by GitBox <gi...@apache.org>.
foreverneverer merged PR #1007:
URL: https://github.com/apache/incubator-pegasus/pull/1007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1007: feat(dup_enhancement#26): update duplicate rpc thrift in go-client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1007:
URL: https://github.com/apache/incubator-pegasus/pull/1007#issuecomment-1158583613
We should unify the IDL *.thrift files, now they are distributed every where, we can do it after rdsn has been merged to Pegasus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1007: feat(dup_enhancement#26): update duplicate rpc thrift in go-client
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1007:
URL: https://github.com/apache/incubator-pegasus/pull/1007#discussion_r899838063
##########
go-client/session/radmin_rpc_types.go:
##########
@@ -15,7 +15,7 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
-*/
+ */
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org