You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/12/21 02:19:49 UTC

[GitHub] [incubator-ratis] runzhiwang opened a new pull request #366: RATIS-1254. Add transfer leadership request and proto

runzhiwang opened a new pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   ## What changes were proposed in this pull request?
   
   subtask of Support rolling upgrade and rollback: Add transfer leadership request and proto
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-1254
   
   ## How was this patch tested?
   
   No need ut.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang closed pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang commented on pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366#issuecomment-749374056


   @szetszwo Thanks for review. CI passed, and I merge it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
szetszwo commented on a change in pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366#discussion_r547055140



##########
File path: ratis-proto/src/main/proto/Raft.proto
##########
@@ -369,6 +369,12 @@ message SetConfigurationRequestProto {
   repeated RaftPeerProto peers = 2;
 }
 
+// transfer leadership request
+message TransferLeadershipRequestProto {
+  RaftRpcRequestProto rpcRequest = 1;
+  RaftPeerProto targetPeer = 2;

Review comment:
       Let's name it newLeader.

##########
File path: ratis-client/src/main/java/org/apache/ratis/client/RaftClient.java
##########
@@ -68,6 +68,9 @@
   /** Send set configuration request to the raft service. */
   RaftClientReply setConfiguration(RaftPeer[] serversInNewConf) throws IOException;
 
+  /** Transfer leadership to the given server.*/
+  RaftClientReply transferLeadership(RaftGroupId group, RaftPeerId target) throws IOException;

Review comment:
       Let's rename the parameter to "newLeader".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang closed pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang closed pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366#issuecomment-749418707


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang closed pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang closed pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang merged pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang closed pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang closed pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] szetszwo commented on pull request #366: RATIS-1254. Add transfer leadership request and proto

Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #366:
URL: https://github.com/apache/incubator-ratis/pull/366#issuecomment-748868456


   Thanks @runzhiwang .  Will review this tomorrow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org