You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shuai-xu <gi...@git.apache.org> on 2017/02/14 06:59:19 UTC
[GitHub] flink pull request #3306: [FLINK-5793] [runtime] fix running slot may not be...
GitHub user shuai-xu opened a pull request:
https://github.com/apache/flink/pull/3306
[FLINK-5793] [runtime] fix running slot may not be add to AllocatedMap in SlotPool bug
This pr is for jira #[5793](https://issues.apache.org/jira/browse/FLINK-5793)
In SlotPool, when a slot is returned by a finished task, it will try to find a
pending request mataching it. If found, will give the slot to the request, but
not add the slot to AllocatedMap.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shuai-xu/flink jira-5793
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3306.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3306
----
commit 11fe5ae90bb912f88b86aa84124b7b453177a819
Author: shuai.xus <sh...@alibaba-inc.com>
Date: 2017-02-14T06:56:41Z
[FLINK-5793] [runtime] fix running slot may not be add to AllocatedMap in SlotPool bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3306: [FLINK-5793] [runtime] fix running slot may not be add to...
Posted by shuai-xu <gi...@git.apache.org>.
Github user shuai-xu commented on the issue:
https://github.com/apache/flink/pull/3306
@StephanEwen done, add unittest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3306: [FLINK-5793] [runtime] fix running slot may not be add to...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3306
Good fix, thanks.
Could you add a quick unit test for the bug? That way we can make sure the bug is not accidentally re-introduced by another patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3306: [FLINK-5793] [runtime] fix running slot may not be...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3306
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3306: [FLINK-5793] [runtime] fix running slot may not be add to...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3306
Thanks looks good!
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---