You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/08/08 00:54:45 UTC
Review Request 71247: Added a new agent flag
--allow_chown_docker_volume.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71247/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-9908
https://issues.apache.org/jira/browse/MESOS-9908
Repository: mesos
Description
-------
Added a new agent flag --allow_chown_docker_volume.
Diffs
-----
src/slave/flags.hpp 01834f41f2cd045cdb745e90d7f57fc2948ae024
src/slave/flags.cpp 08ec20b30e7d82ab453c0b96c208ab1c1cc812db
Diff: https://reviews.apache.org/r/71247/diff/1/
Testing
-------
make
Thanks,
Gilbert Song
Re: Review Request 71247: Added a new agent flag
--allow_chown_docker_volume.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71247/#review217120
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 8, 2019, 8:54 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71247/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2019, 8:54 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-9908
> https://issues.apache.org/jira/browse/MESOS-9908
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new agent flag --allow_chown_docker_volume.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp 01834f41f2cd045cdb745e90d7f57fc2948ae024
> src/slave/flags.cpp 08ec20b30e7d82ab453c0b96c208ab1c1cc812db
>
>
> Diff: https://reviews.apache.org/r/71247/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 71247: Added a new agent flag
--allow_chown_docker_volume.
Posted by Gilbert Song <so...@gmail.com>.
> On Aug. 7, 2019, 11:43 p.m., Qian Zhang wrote:
> > I think we also need to update `agent.md`, `operator-http-api.md` (the `GET_FLAGS` call), `upgrades.md` and `CHANGELOG` for this flag.
Updated agent.md
I will update other .md file in a separate patch. Thanks!
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71247/#review217116
-----------------------------------------------------------
On Aug. 7, 2019, 5:54 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71247/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2019, 5:54 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-9908
> https://issues.apache.org/jira/browse/MESOS-9908
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new agent flag --allow_chown_docker_volume.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp 01834f41f2cd045cdb745e90d7f57fc2948ae024
> src/slave/flags.cpp 08ec20b30e7d82ab453c0b96c208ab1c1cc812db
>
>
> Diff: https://reviews.apache.org/r/71247/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 71247: Added a new agent flag
--allow_chown_docker_volume.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71247/#review217116
-----------------------------------------------------------
I think we also need to update `agent.md`, `operator-http-api.md` (the `GET_FLAGS` call), `upgrades.md` and `CHANGELOG` for this flag.
src/slave/flags.hpp
Lines 63 (patched)
<https://reviews.apache.org/r/71247/#comment304379>
I think we do not need `allow` here just like the other similar bool flag `switch_user`, maybe just `docker_volume_chown` which is also consistent with the flag above it (`docker_volume_checkpoint_dir`).
- Qian Zhang
On Aug. 8, 2019, 8:54 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71247/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2019, 8:54 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-9908
> https://issues.apache.org/jira/browse/MESOS-9908
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new agent flag --allow_chown_docker_volume.
>
>
> Diffs
> -----
>
> src/slave/flags.hpp 01834f41f2cd045cdb745e90d7f57fc2948ae024
> src/slave/flags.cpp 08ec20b30e7d82ab453c0b96c208ab1c1cc812db
>
>
> Diff: https://reviews.apache.org/r/71247/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 71247: Added a new agent flag
--allow_chown_docker_volume.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71247/
-----------------------------------------------------------
(Updated Aug. 8, 2019, 4:55 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-9908
https://issues.apache.org/jira/browse/MESOS-9908
Repository: mesos
Description
-------
Added a new agent flag --allow_chown_docker_volume.
Diffs (updated)
-----
docs/configuration/agent.md 325a37e095f861f11929218aa5c873b2c714b490
src/slave/flags.hpp 01834f41f2cd045cdb745e90d7f57fc2948ae024
src/slave/flags.cpp 08ec20b30e7d82ab453c0b96c208ab1c1cc812db
Diff: https://reviews.apache.org/r/71247/diff/2/
Changes: https://reviews.apache.org/r/71247/diff/1-2/
Testing
-------
make
Thanks,
Gilbert Song