You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2026/09/22 10:25:20 UTC
[PR] [FLINK-40747][jdbc] PreparedSplitterEnumerator.of(sql) yields one split [flink-connector-jdbc]
MartijnVisser opened a new pull request, #243:
URL: https://github.com/apache/flink-connector-jdbc/pull/243
## What is the purpose of the change
- `PreparedSplitterEnumerator.of(sqlTemplate)` built the enumerator with an empty parameter matrix, so a query without parameters produced no split and the source finished without reading a row. It is the first example in the `JdbcSourceBuilder` javadoc.
## Brief change log
- `of(sqlTemplate)` builds one empty parameter row, which the split reader binds as no parameters
- `SqlSplitterEnumerator` is unchanged: an empty matrix still gives no split, which `SlideTimingSplitterEnumerator` relies on between windows
- new `PreparedSplitterEnumeratorTest`
## Verifying this change
This change added tests and can be verified as follows:
- `PreparedSplitterEnumeratorTest` fails on `main` with `Expected size: 1 but was: 0` and passes with the change
- `SlideTimingSplitterEnumeratorTest`, `JdbcSourceITCase` and `JdbcSourceStreamRelatedITCase` pass
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Fable 5.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40747][jdbc] PreparedSplitterEnumerator.of(sql) yields one split [flink-connector-jdbc]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #243:
URL: https://github.com/apache/flink-connector-jdbc/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40747][jdbc] PreparedSplitterEnumerator.of(sql) yields one split [flink-connector-jdbc]
Posted by "eskabetxe (via GitHub)" <gi...@apache.org>.
eskabetxe commented on code in PR #243:
URL: https://github.com/apache/flink-connector-jdbc/pull/243#discussion_r4138132609
##########
flink-connector-jdbc-core/src/test/java/org/apache/flink/connector/jdbc/core/datastream/source/JdbcSourceITCase.java:
##########
@@ -159,6 +160,25 @@ void testGetLineageVertex() {
}
/** A sink function to collect the records. */
Review Comment:
This belongs to TestingSinkFunction below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40747][jdbc] PreparedSplitterEnumerator.of(sql) yields one split [flink-connector-jdbc]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #243:
URL: https://github.com/apache/flink-connector-jdbc/pull/243#issuecomment-5898148195
@eskabetxe can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org