You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Vincent Hennebert <vi...@anyware-tech.com> on 2008/01/22 12:10:49 UTC

Re: svn commit: r614156 - in /xmlgraphics/fop/trunk/src/documentation/content/xdocs: site.xml trunk/embedding.xml trunk/graphics.xml trunk/running.xml trunk/servlets.xml

Hi Jeremias,

Nice job. I’d have a few comments/questions.

I’ll criticise a bit in the next paragraph, but please don’t feel 
offended and take it as “positive criticism”. I realise it’s not easy to 
write doc, and it’s already great to take the time for it. But since I’m 
lacking of skills in that area I can’t improve it by myself.

I think it’s not clear from a user point of vue whether JAI is no longer 
needed or not. In the introduction it’s written that “Jimi and JAI are 
no longer supported”. But footnote 1 in the following section states: 
“Requires the presence of JAI [...]”.

I understand it as: the JAI API will no longer be used directly, but 
only through the generic Java Image I/O API. Is that right? Maybe the 
text could be re-phrased a bit.

That said, does a user really need this information? Maybe it’s enough 
to say that Jimi is no longer needed, and that JAI remains an optional 
dependency that adds support for more image formats. Without entering 
too much the details of code changes.

Also, build.xml still contains checks about the presence of Jimi (and 
JAI). I guess it’s no longer required and can be removed now?


<snip/>
> -      <section id="svg-pdf-text">
> -        <title>Placing SVG Text into PDF and PostScript</title>
> -        <p>If possible, Batik will use normal PDF or PostScript text when inserting text. It does
> -this by checking if the text can be drawn normally and the font is
> -supported. This example svg <a href="../dev/svg/text.svg">text.svg</a> /
> -<!--link href="../dev/svg/text.pdf"-->text.pdf<!--/link-->
> -shows how various types and effects with text are handled.
> -Note that tspan and outlined text are not yet implemented.</p>

Is that still true with your recent work on improving text support for 
SVG images?

Thanks,
Vincent


-- 
Vincent Hennebert                            Anyware Technologies
http://people.apache.org/~vhennebert         http://www.anyware-tech.com
Apache FOP Committer                         FOP Development/Consulting

Re: svn commit: r614156 - in /xmlgraphics/fop/trunk/src/documentation/content/xdocs: site.xml trunk/embedding.xml trunk/graphics.xml trunk/running.xml trunk/servlets.xml

Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
On 22.01.2008 13:35:37 Jeremias Maerki wrote:
<snip/>
> > Also, build.xml still contains checks about the presence of Jimi (and 
> > JAI). I guess it’s no longer required and can be removed now?
> 
> Yes.

Correction: this can be removed when we're sure we don't need the old
classes anymore, either. I still don't know how many people have worked
with the new image stuff. No feedback may be a good sign, but who knows...

<snip/>


Jeremias Maerki


Re: svn commit: r614156 - in /xmlgraphics/fop/trunk/src/documentation/content/xdocs: site.xml trunk/embedding.xml trunk/graphics.xml trunk/running.xml trunk/servlets.xml

Posted by Vincent Hennebert <vi...@anyware-tech.com>.
Jeremias Maerki wrote:
<snip/>
>> I think it’s not clear from a user point of vue whether JAI is no longer 
>> needed or not. In the introduction it’s written that “Jimi and JAI are 
>> no longer supported”. But footnote 1 in the following section states: 
>> “Requires the presence of JAI [...]”.
>>
>> I understand it as: the JAI API will no longer be used directly, but 
>> only through the generic Java Image I/O API. Is that right? Maybe the 
>> text could be re-phrased a bit.
> 
> Yes. I made a note on the difference.
> 
>> That said, does a user really need this information? Maybe it’s enough 
>> to say that Jimi is no longer needed, and that JAI remains an optional 
>> dependency that adds support for more image formats. Without entering 
>> too much the details of code changes.
> 
> JAI is no longer a dependency, not even an optional one. I haven't
> reimplemented a plug-in for it. JAI Image I/O Tools is an optional
> add-on for any Java >=1.4. FOP can simply make use of the additional
> codecs through Java's ImageIO API if it is present.

So IIUC that means that my current JAI library will no longer be any 
useful, and that if I want to use the advanced functionalities of JAI 
Image I/O I have to download this other bundle and install it on my Java 
system? I guess there’s no chance that I will have JAI Image I/O support 
simply by leaving my current JAI jar in the classpath? I’m sure many 
users will think of that. That ‘JAI’ in both names is slightly 
unfortunate.

Looks like some proper “how to upgrade” doc will be needed in this area. 
If I can’t get to sleep tonight...

Thanks for the clarification,
Vincent


-- 
Vincent Hennebert                            Anyware Technologies
http://people.apache.org/~vhennebert         http://www.anyware-tech.com
Apache FOP Committer                         FOP Development/Consulting

Re: svn commit: r614156 - in /xmlgraphics/fop/trunk/src/documentation/content/xdocs: site.xml trunk/embedding.xml trunk/graphics.xml trunk/running.xml trunk/servlets.xml

Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Thanks for the hints. Comments inline...

On 22.01.2008 12:10:49 Vincent Hennebert wrote:
> Hi Jeremias,
> 
> Nice job. I’d have a few comments/questions.
> 
> I’ll criticise a bit in the next paragraph, but please don’t feel 
> offended and take it as “positive criticism”. I realise it’s not easy to 
> write doc, and it’s already great to take the time for it. But since I’m 
> lacking of skills in that area I can’t improve it by myself.
> 
> I think it’s not clear from a user point of vue whether JAI is no longer 
> needed or not. In the introduction it’s written that “Jimi and JAI are 
> no longer supported”. But footnote 1 in the following section states: 
> “Requires the presence of JAI [...]”.
> 
> I understand it as: the JAI API will no longer be used directly, but 
> only through the generic Java Image I/O API. Is that right? Maybe the 
> text could be re-phrased a bit.

Yes. I made a note on the difference.

> That said, does a user really need this information? Maybe it’s enough 
> to say that Jimi is no longer needed, and that JAI remains an optional 
> dependency that adds support for more image formats. Without entering 
> too much the details of code changes.

JAI is no longer a dependency, not even an optional one. I haven't
reimplemented a plug-in for it. JAI Image I/O Tools is an optional
add-on for any Java >=1.4. FOP can simply make use of the additional
codecs through Java's ImageIO API if it is present.

> Also, build.xml still contains checks about the presence of Jimi (and 
> JAI). I guess it’s no longer required and can be removed now?

Yes.

> 
> <snip/>
> > -      <section id="svg-pdf-text">
> > -        <title>Placing SVG Text into PDF and PostScript</title>
> > -        <p>If possible, Batik will use normal PDF or PostScript text when inserting text. It does
> > -this by checking if the text can be drawn normally and the font is
> > -supported. This example svg <a href="../dev/svg/text.svg">text.svg</a> /
> > -<!--link href="../dev/svg/text.pdf"-->text.pdf<!--/link-->
> > -shows how various types and effects with text are handled.
> > -Note that tspan and outlined text are not yet implemented.</p>
> 
> Is that still true with your recent work on improving text support for 
> SVG images?

Yes. SVG fonts are still painted as shapes and certain other very
special SVG cases which I don't remember right now.


Jeremias Maerki