You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by GitBox <gi...@apache.org> on 2026/08/25 04:09:22 UTC
[GH] (texera/gh-readonly-queue/main/pr-7948-319859571e30d123a50081a918815d9b65b4300f): Workflow run "Required Checks" failed!
The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-7948-319859571e30d123a50081a918815d9b65b4300f has failed.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run:
3638adf942e647044ff2b039362031c151ec2767 / Kary Zheng <15...@users.noreply.github.com>
feat(frontend): let the upload drop zone grow with its content (#7948)
### What changes were proposed in this PR?
The "Create New Version" uploader sits in the resizable side panel on
the dataset detail page. `ngx-file-drop` fixes both its drop zone and
content at `height: 100px`, and the prompt plus the browse button
already stack taller than that, so the content spills past the dotted
border. Narrowing the panel to its 150px minimum makes it much worse:
the prompt wraps to four lines and the button, sized `width: 60%`, ends
up narrower than its own label.
This lets the box grow with what is inside it instead of clipping. The
drop zone and its content keep 100px as a minimum and take their height
from the content. The button sizes to the available width, wraps its
label, and grows with it.
Two overrides need more than a plain class selector. The library's own
rule has the same specificity as a `::ng-deep` class selector, so the
drop zone height needs the extra `ngx-file-drop` element selector to
win. The button needs an explicit `height: auto` because ant-design's
`.ant-btn` sets a fixed `32px`.
One stylesheet, `files-uploader.component.scss`. No template or
TypeScript change.
Before, with the panel at its 150px minimum. The prompt runs above the
dotted border and the button label is cut off on both sides.
<img width="1523" height="994" alt="Screenshot 2026-08-24 at 3 28 12 PM"
src="https://github.com/user-attachments/assets/dd073df2-eb39-4d7a-876d-dedeb09695d2"
/>
After, same width, zoomed in on the uploader. Everything sits inside the
border.
<img width="382" height="642" alt="upload-dropzone-after"
src="https://github.com/user-attachments/assets/289c0dd9-bb1d-4e86-9530-6ebb005070c0"
/>
Measured at that width:
| | before | after |
|---|---|---|
| drop zone height | 100px, fixed | 225px, follows content |
| prompt overflow above the border | 55.3px | none |
| prompt overflow below the border | 59.3px | none |
| button overflow left and right | 1.2px | none |
| button label clipped | yes | no |
### Any related issues, documentation, discussions?
Fixes #7947.
### How was this PR tested?
Verified by hand in the running app at the panel's minimum width, as
shown in the screenshots above. This is a stylesheet-only change with no
behavior to assert on.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
Co-authored-by: Claude Opus 5 (1M context) <no...@anthropic.com>
Report URL: https://github.com/apache/texera/actions/runs/32806900369
With regards,
GitHub Actions via GitBox