You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/02/27 00:47:04 UTC

[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment
URL: https://github.com/apache/beam/pull/10621#discussion_r384853099
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/stager.py
 ##########
 @@ -377,34 +436,33 @@ def _stage_jar_packages(self, jar_packages, staging_location, temp_dir):
 
     for package in local_packages:
       basename = os.path.basename(package)
-      staged_path = FileSystems.join(staging_location, basename)
-      self.stage_artifact(package, staged_path)
-      resources.append(basename)
+      resources.append((package, basename))
 
     return resources
 
-  def _stage_extra_packages(self, extra_packages, staging_location, temp_dir):
-    # type: (...) -> List[str]
+  @staticmethod
+  def _stage_extra_packages(extra_packages, temp_dir):
 
 Review comment:
   Similarly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services