[jira] [Commented] (PHOENIX-5541) Redundant Global Mutable Index Writes on Legacy Indexer

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958236#comment-16958236 ] 

Hadoop QA commented on PHOENIX-5541:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12983855/PHOENIX-5541.patch
  against master branch at commit a9ec9806536697f4683ed3321745e0b06f232bdf.
  ATTACHMENT ID: 12983855

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3063//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3063//console

This message is automatically generated.

> Redundant Global Mutable Index Writes on Legacy Indexer
> -------------------------------------------------------
>
>                 Key: PHOENIX-5541
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5541
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 5.1.0, 4.14.3
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>         Attachments: PHOENIX-5541.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In the inaccurately-named IndexWriter.writeAndKillYourselfOnFailure, there's the following code:
> {code:java}
> public void writeAndKillYourselfOnFailure(Collection<Pair<Mutation, byte[]>> indexUpdates, boolean allowLocalUpdates, int clientVersion) throws IOException { 
> // convert the strings to htableinterfaces to which we can talk and group by TABLE Multimap<HTableInterfaceReference, Mutation> toWrite = resolveTableReferences(indexUpdates); 
> writeAndKillYourselfOnFailure(toWrite, allowLocalUpdates, clientVersion); writeAndHandleFailure(toWrite, allowLocalUpdates, clientVersion); 
> }
> {code}
> writeAndKillYourselfOnFailure and writeAndHandleFailure seem to be identical, which means that calling them both will result in the same index Cells being written twice. This shouldn't affect correctness, but it will affect performance and (temporarily, until compaction) storage



--
This message was sent by Atlassian Jira
(v8.3.4#803005)