[GitHub] eiri commented on a change in pull request #1187: [WIP] Couchdb 3326 clustered purge

[GitBox <gi...@apache.org>]

eiri commented on a change in pull request #1187: [WIP] Couchdb 3326 clustered purge
URL: https://github.com/apache/couchdb/pull/1187#discussion_r173852178
 
 

 ##########
 File path: src/couch/src/couch_bt_engine_compactor.erl
 ##########
 @@ -58,6 +58,7 @@ start(#st{} = St, DbName, Options, Parent) ->
     NewSt3 = sort_meta_data(NewSt2),
     NewSt4 = commit_compaction_data(NewSt3),
     NewSt5 = copy_meta_data(NewSt4),
+    couch_db_plugin:before_copy_purge_info(DbName),
 
 Review comment:
   This is an oddly specific place and name for a plugin's hook, in my opinion. The idea behind epi plugins that they could be used to extend common public functionality to allow to do various things. The `before_copy_purge_info` is  rather obscure code point and I don't imagine there are much could be done with it or even many devs would _know_ what to do with it. In my opinion the plugin hook should be in [start_compaction](https://github.com/apache/couchdb/blob/master/src/couch/src/couch_bt_engine.erl#L492) and named `before_compaction`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services