[jira] [Commented] (ZOOKEEPER-1305) zookeeper.c:prepend_string func can dereference null ptr

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165531#comment-13165531 ] 

Hadoop QA commented on ZOOKEEPER-1305:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12504766/ZOOKEEPER-1305.patch
  against trunk revision 1208979.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/814//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/814//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/814//console

This message is automatically generated.
                
> zookeeper.c:prepend_string func can dereference null ptr
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-1305
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1305
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.3
>         Environment: All
>            Reporter: Daniel Lescohier
>            Assignee: Daniel Lescohier
>              Labels: patch
>             Fix For: 3.5.0, 3.4.1
>
>         Attachments: ZOOKEEPER-1305.patch, ZOOKEEPER-1305.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> All the callers of the function prepend_string make a call to prepend_string before checking that zhandle_t *zh is not null. At the top of prepend_string, zh is dereferenced without checking for a null ptr:
> static char* prepend_string(zhandle_t *zh, const char* client_path) {
>     char *ret_str;
>     if (zh->chroot == NULL)
>         return (char *) client_path;
> I propose fixing this by adding the check here in prepend_string:
> static char* prepend_string(zhandle_t *zh, const char* client_path) {
>     char *ret_str;
>     if (zh==NULL || zh->chroot == NULL)
>         return (char *) client_path;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira