You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com> on 2016/02/13 01:13:31 UTC
Review Request 43550: SAMZA-836: fix unit test failure w/
FlushOptions() in rocksdbjni-3.13.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43550/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-836
https://issues.apache.org/jira/browse/SAMZA-836
Repository: samza
Description
-------
SAMZA-836: fix unit test failure w/ FlushOptions() in rocksdbjni-3.13.1
Diffs
-----
samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala 0c86a5a1550894645c2ab0010b70b124ad3dbd98
Diff: https://reviews.apache.org/r/43550/diff/
Testing
-------
Ran the full set of unit tests both on Mac and Linux and both passed.
Thanks,
Yi Pan (Data Infrastructure)
Re: Review Request 43550: SAMZA-836: fix unit test failure w/
FlushOptions() in rocksdbjni-3.13.1
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43550/#review119118
-----------------------------------------------------------
Ship it!
Ship It!
- Navina Ramesh
On Feb. 13, 2016, 12:13 a.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43550/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2016, 12:13 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-836
> https://issues.apache.org/jira/browse/SAMZA-836
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-836: fix unit test failure w/ FlushOptions() in rocksdbjni-3.13.1
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala 0c86a5a1550894645c2ab0010b70b124ad3dbd98
>
> Diff: https://reviews.apache.org/r/43550/diff/
>
>
> Testing
> -------
>
> Ran the full set of unit tests both on Mac and Linux and both passed.
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
Re: Review Request 43550: SAMZA-836: fix unit test failure w/
FlushOptions() in rocksdbjni-3.13.1
Posted by Jake Maes <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43550/#review119120
-----------------------------------------------------------
Ship it!
Ship It!
- Jake Maes
On Feb. 13, 2016, 12:13 a.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43550/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2016, 12:13 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-836
> https://issues.apache.org/jira/browse/SAMZA-836
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-836: fix unit test failure w/ FlushOptions() in rocksdbjni-3.13.1
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala 0c86a5a1550894645c2ab0010b70b124ad3dbd98
>
> Diff: https://reviews.apache.org/r/43550/diff/
>
>
> Testing
> -------
>
> Ran the full set of unit tests both on Mac and Linux and both passed.
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
Re: Review Request 43550: SAMZA-836: fix unit test failure w/
FlushOptions() in rocksdbjni-3.13.1
Posted by Tao Feng <fe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43550/#review119113
-----------------------------------------------------------
Ship it!
Ship It!
- Tao Feng
On Feb. 13, 2016, 12:13 a.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43550/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2016, 12:13 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-836
> https://issues.apache.org/jira/browse/SAMZA-836
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-836: fix unit test failure w/ FlushOptions() in rocksdbjni-3.13.1
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala 0c86a5a1550894645c2ab0010b70b124ad3dbd98
>
> Diff: https://reviews.apache.org/r/43550/diff/
>
>
> Testing
> -------
>
> Ran the full set of unit tests both on Mac and Linux and both passed.
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
Re: Review Request 43550: SAMZA-836: fix unit test failure w/
FlushOptions() in rocksdbjni-3.13.1
Posted by Boris Shkolnik <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43550/#review121371
-----------------------------------------------------------
Ship it!
I wish we understood the reason for it.
- Boris Shkolnik
On Feb. 13, 2016, 12:13 a.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43550/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2016, 12:13 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-836
> https://issues.apache.org/jira/browse/SAMZA-836
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-836: fix unit test failure w/ FlushOptions() in rocksdbjni-3.13.1
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala 0c86a5a1550894645c2ab0010b70b124ad3dbd98
>
> Diff: https://reviews.apache.org/r/43550/diff/
>
>
> Testing
> -------
>
> Ran the full set of unit tests both on Mac and Linux and both passed.
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>