You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Animesh Chaturvedi <an...@citrix.com> on 2013/02/12 07:44:35 UTC
RE: Review Request: Store NetworkServiceProvider connectivity
service configuration in database.
Hiroaki
Can you update the patch to current state of master?
Thanks
Animesh
> -----Original Message-----
> From: Hugo Trippaers [mailto:noreply@reviews.apache.org] On Behalf Of Hugo
> Trippaers
> Sent: Tuesday, January 29, 2013 1:44 AM
> To: cloudstack; Hiroaki Kawai; Hugo Trippaers
> Subject: Re: Review Request: Store NetworkServiceProvider connectivity service
> configuration in database.
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8294/#review15794
> -----------------------------------------------------------
>
>
> The change looks good. Could you update the patch to the latest state of
> master?
>
> - Hugo Trippaers
>
>
> On Nov. 30, 2012, 12:17 p.m., Hiroaki Kawai wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8294/
> > -----------------------------------------------------------
> >
> > (Updated Nov. 30, 2012, 12:17 p.m.)
> >
> >
> > Review request for cloudstack.
> >
> >
> > Description
> > -------
> >
> > There are 13 services defined in com.cloud.network.Network.Service , but db
> schema has 12 services with connecitivity missing in
> `cloud`.`physical_network_service_providers` . This patch will fix this. In the
> cloudstack api response, we'll see Connectivity service is enabled in NiciraNvp
> network service provider servicelist like this:
> >
> > {
> > "listnetworkserviceprovidersresponse": {
> > "count": 1,
> > "networkserviceprovider": [
> > {
> > "physicalnetworkid": "80bf64a1-c5ca-4eb1-810e-76917a317d59",
> > "servicelist": [
> > "Connectivity"
> > ],
> > "name": "NiciraNvp",
> > "destinationphysicalnetworkid": "0",
> > "state": "Disabled",
> > "id": "efb45f75-9fd7-43aa-9937-b5c871971c00"
> > }
> > ]
> > }
> > }
> >
> >
> > Diffs
> > -----
> >
> > api/src/com/cloud/network/PhysicalNetworkServiceProvider.java 1b91311
> > packaging/centos63/package.sh 83c0e5e
> > server/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.java
> 12b08af
> > server/src/com/cloud/upgrade/dao/Upgrade40to41.java 5067f39
> > setup/db/create-schema.sql fff084e
> > setup/db/db/schema-40to41.sql PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/8294/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Hiroaki Kawai
> >
> >