[GitHub] [dolphinscheduler] songjianet commented on a diff in pull request #9800: [Fix-#9799] the password echo is empty

[GitBox <gi...@apache.org>]

songjianet commented on code in PR #9800:
URL: https://github.com/apache/dolphinscheduler/pull/9800#discussion_r859330460


##########
dolphinscheduler-ui-next/src/views/datasource/list/index.tsx:
##########
@@ -120,7 +120,7 @@ const list = defineComponent({
                   <div class={styles['conditions-search-input']}>
                     <NInput
                       v-model={[this.searchVal, 'value']}
-                      placeholder={`${t('datasource.search_input_tips')}`}
+                      placeholder={`${t('datasource.datasource_name_tips')}`}

Review Comment:
   It is not recommended to change here, and will be optimized in the future.



##########
dolphinscheduler-ui-next/src/views/datasource/list/use-detail.ts:
##########
@@ -25,6 +25,7 @@ import {
 } from '@/service/modules/data-source'
 import { useI18n } from 'vue-i18n'
 import type { IDataSource } from './types'
+import { IDataSourceDetail } from './types'

Review Comment:
   To import types please use `import type` .



##########
dolphinscheduler-ui-next/src/views/datasource/list/detail.tsx:
##########
@@ -264,9 +264,10 @@ const DetailModal = defineComponent({
                 <NFormItem
                   label={t('datasource.user_password')}
                   path='password'
+                  show-require-mark
                 >
                   <NInput
-                    class='input-password'
+                    class='input-pessword'

Review Comment:
   If you make changes here, please modify e2e synchronously.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org