You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/02/04 13:48:04 UTC
[GitHub] [singa] joddiy opened a new pull request #592: fix bugs for some
cases of onnx
joddiy opened a new pull request #592: fix bugs for some cases of onnx
URL: https://github.com/apache/singa/pull/592
* We can support the input of clip like [x, min, max], [x, min], [x], cannot support like [x, max]
* Add shape check of auto_pad for conv2d of onnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] joddiy commented on issue #592: fix bugs for some cases of
onnx
Posted by GitBox <gi...@apache.org>.
joddiy commented on issue #592: fix bugs for some cases of onnx
URL: https://github.com/apache/singa/pull/592#issuecomment-584596683
> have you updated the clip function to support [x, min, max], [x, min], [x]?
> ready for merge?
Yes, I've already supported the [x, min, max], [x, min], [x].
But if we want to support [x, max], because it doesn't give the parameters with the default order, we must change lots of code...
Can merge now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles commented on issue #592: fix bugs for some cases of
onnx
Posted by GitBox <gi...@apache.org>.
nudles commented on issue #592: fix bugs for some cases of onnx
URL: https://github.com/apache/singa/pull/592#issuecomment-584622106
does onnx require to support [x, max]?
I will merge this PR, pls create an issue for [x, max] if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles commented on issue #592: fix bugs for some cases of
onnx
Posted by GitBox <gi...@apache.org>.
nudles commented on issue #592: fix bugs for some cases of onnx
URL: https://github.com/apache/singa/pull/592#issuecomment-584483433
have you updated the clip function to support [x, min, max], [x, min], [x]?
ready for merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles merged pull request #592: fix bugs for some cases of
onnx
Posted by GitBox <gi...@apache.org>.
nudles merged pull request #592: fix bugs for some cases of onnx
URL: https://github.com/apache/singa/pull/592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services