You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/08/29 10:29:08 UTC
Review Request: Fixed bugs in linux/fs.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6826/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
Description
-------
Fixed a bug in linux/fs.cpp due to typo (missed due to MACRO guard).
Also, make mutex static local variables (instead of global static variables).
Diffs
-----
src/linux/fs.cpp 8bcc2cd
Diff: https://reviews.apache.org/r/6826/diff/
Testing
-------
on linux machine. make check
Thanks,
Jie Yu
Re: Review Request: Fixed bugs in linux/fs.cpp.
Posted by Jie Yu <yu...@gmail.com>.
Closed. Thank you for solving this.
- Jie
On Wed, Aug 29, 2012 at 1:42 PM, Ben Mahler <be...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6826/
>
> thanks jie, you may want to close this, since I've subsumed it within: https://reviews.apache.org/r/6812/
> if you like, try patching my change in and see whether it builds on your ubuntu system
>
>
> - Ben
>
> On August 29th, 2012, 8:29 a.m., Jie Yu wrote:
> Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
> By Jie Yu.
>
> *Updated Aug. 29, 2012, 8:29 a.m.*
> Description
>
> Fixed a bug in linux/fs.cpp due to typo (missed due to MACRO guard).
>
> Also, make mutex static local variables (instead of global static variables).
>
> Testing
>
> on linux machine. make check
>
> Diffs
>
> - src/linux/fs.cpp (8bcc2cd)
>
> View Diff <https://reviews.apache.org/r/6826/diff/>
>
Re: Review Request: Fixed bugs in linux/fs.cpp.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6826/#review10849
-----------------------------------------------------------
thanks jie, you may want to close this, since I've subsumed it within: https://reviews.apache.org/r/6812/
if you like, try patching my change in and see whether it builds on your ubuntu system
- Ben Mahler
On Aug. 29, 2012, 8:29 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6826/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2012, 8:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
>
>
> Description
> -------
>
> Fixed a bug in linux/fs.cpp due to typo (missed due to MACRO guard).
>
> Also, make mutex static local variables (instead of global static variables).
>
>
> Diffs
> -----
>
> src/linux/fs.cpp 8bcc2cd
>
> Diff: https://reviews.apache.org/r/6826/diff/
>
>
> Testing
> -------
>
> on linux machine. make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Fixed bugs in linux/fs.cpp.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6826/
-----------------------------------------------------------
(Updated Aug. 29, 2012, 8:29 a.m.)
Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
Description
-------
Fixed a bug in linux/fs.cpp due to typo (missed due to MACRO guard).
Also, make mutex static local variables (instead of global static variables).
Diffs
-----
src/linux/fs.cpp 8bcc2cd
Diff: https://reviews.apache.org/r/6826/diff/
Testing
-------
on linux machine. make check
Thanks,
Jie Yu