Re: [PR] key-based range options to shell "scan" command [accumulo]

["ivakegg (via GitHub)" <gi...@apache.org>]

ivakegg commented on code in PR #5959:
URL: https://github.com/apache/accumulo/pull/5959#discussion_r2867749527


##########
shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java:
##########
@@ -409,16 +470,35 @@ public Options getOptions() {
         "scan authorizations (all user auths are used if this argument is not specified)");
     optStartRowExclusive = new Option("be", "begin-exclusive", false,
         "make start row exclusive (by default it's inclusive)");
-    optStartRowExclusive.setArgName("begin-exclusive");
     optEndRowExclusive = new Option("ee", "end-exclusive", false,
         "make end row exclusive (by default it's inclusive)");
-    optEndRowExclusive.setArgName("end-exclusive");
     scanOptRow = new Option("r", "row", true, "row to scan");
     scanOptColumns = new Option("c", "columns", true,
         "comma-separated columns. This option is mutually exclusive with cf and cq");
     scanOptCf = new Option("cf", "column-family", true, "column family to scan.");
     scanOptCq = new Option("cq", "column-qualifier", true, "column qualifier to scan");
 
+    scanOptBeginKeyRow = new Option("bkr", "begin-key-r", true, "key-based range start row");
+    scanOptBeginKeyCf =
+        new Option("bkcf", "begin-key-cf", true, "key-based range start column family");
+    scanOptBeginKeyCq =
+        new Option("bkcq", "begin-key-cq", true, "key-based range start column qualifier");
+    scanOptBeginKeyTs = new Option("bkts", "begin-key-ts", true, "key-based range start timestamp");

Review Comment:
   I think the start/end TS may be overkill here.  I don't mind it but just saying it is not required.  Definitely need the start/end cf and cq options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org