[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #198: [WIP][YUNIKORN-366] Add rest API to update queue configuration

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #198:
URL: https://github.com/apache/incubator-yunikorn-core/pull/198#discussion_r477394148



##########
File path: pkg/plugins/types.go
##########
@@ -62,3 +63,7 @@ type ContainerSchedulingStateUpdater interface {
 	// the shim side implementation must be thread safe
 	Update(request *si.UpdateContainerSchedulingStateRequest)
 }
+
+type ConfigMapPlugin interface {
+	UpdateConfigMap(args *si.ConfigMapArgs) (string, error)

Review comment:
       Renamed

##########
File path: pkg/webservice/handlers.go
##########
@@ -339,3 +342,55 @@ func getClusterConfig(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 	}
 }
+
+var mutex sync.Mutex

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org