You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/10 09:31:33 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #4788: ui: Fix breadcrumb discrepancy

davidjumani opened a new pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788


   ### Description
   
   This PR aligns the breadcrumb with the info card name
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   #### Before :
   
   ![Screenshot from 2021-03-10 15-00-19](https://user-images.githubusercontent.com/8244774/110607605-5e868200-81b1-11eb-9788-26dde4776228.png)
   
   #### After :
   
   ![Screenshot from 2021-03-10 15-00-46](https://user-images.githubusercontent.com/8244774/110607653-69d9ad80-81b1-11eb-8652-866a8e9a544a.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788#issuecomment-796336610


   @utchoang Done!
   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788#issuecomment-795155616


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4788 (JID-3862)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788#issuecomment-796339710


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4788 (SL-JID-19)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788#issuecomment-795149122


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788#issuecomment-796530360


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] utchoang commented on pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788#issuecomment-796329599


   @davidjumani can you change the base branch of the PR and rebase your PR branch to 4.15?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788#issuecomment-795149808


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4788: ui: Fix breadcrumb discrepancy

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4788:
URL: https://github.com/apache/cloudstack/pull/4788#issuecomment-796337193


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org