Re: Converting to cmake

[Pierre-Alexandre St-Jean <pa...@stjean.me>]

Here is my advancement on making thrift compile with cmake instead of
autotools.

I managed to compile the compiler with the flex and bison dependencies and
the cpp generator plugged in (would not be hard to plug others).

What you fear happens tough.

-There is no more configure script.
-Cmake must be there (to create the makefiles).
-The switch to enable or disable a compiler option is ackward ( cmake
-DWITH_CPP=NO) the -D is obligatory or i would have replaced it with
-WITH_CPP.

What is good tough is that i learned a lot about thrift doing this part of
the conversion.
This is what got out of this. Do you want me to send a patch to see what
happened ?
--
Pierre-Alexandre St-Jean

Re: Converting to cmake

[David Reiss <dr...@facebook.com>]

Sure.

Pierre-Alexandre St-Jean wrote:
> Here is my advancement on making thrift compile with cmake instead of
> autotools.
> 
> I managed to compile the compiler with the flex and bison dependencies and
> the cpp generator plugged in (would not be hard to plug others).
> 
> What you fear happens tough.
> 
> -There is no more configure script.
> -Cmake must be there (to create the makefiles).
> -The switch to enable or disable a compiler option is ackward ( cmake
> -DWITH_CPP=NO) the -D is obligatory or i would have replaced it with
> -WITH_CPP.
> 
> What is good tough is that i learned a lot about thrift doing this part of
> the conversion.
> This is what got out of this. Do you want me to send a patch to see what
> happened ?
> --
> Pierre-Alexandre St-Jean