[GitHub] [superset] villebro commented on a change in pull request #18250: feat: Embedded SDK

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #18250:
URL: https://github.com/apache/superset/pull/18250#discussion_r798484233



##########
File path: .github/workflows/embedded-sdk-test.yml
##########
@@ -0,0 +1,27 @@
+name: embedded-sdk-test-workflow
+
+on:
+  pull_request:
+    paths:
+      - "superset-embedded-sdk/**"

Review comment:
       In other similar flows we have slightly more specific `on`s to avoid CI running on Draft PRs. Something like this perhaps?
   ```
   on:
     push:
       branches:
         - 'master'
     pull_request:
       paths:
         - "superset-embedded-sdk/**"
       types: [synchronize, opened, reopened, ready_for_review]
   ```

##########
File path: superset-embedded-sdk/.gitignore
##########
@@ -0,0 +1,3 @@
+bundle
+dist
+lib

Review comment:
       Any need to add `node_modules` or other typical cruft here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org