You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2012/05/02 19:55:13 UTC

Review Request: oozie-827: StatusTransitService fails to run if a stale reference to coord job is present

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4970/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

https://issues.apache.org/jira/browse/OOZIE-827

Patch for 3.2 and trunk


This addresses bug oozie-827.
    https://issues.apache.org/jira/browse/oozie-827


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1332945 
  trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1332945 

Diff: https://reviews.apache.org/r/4970/diff


Testing
-------


Thanks,

Virag


Re: Review Request: oozie-827: StatusTransitService fails to run if a stale reference to coord job is present

Posted by Virag Kothari <vi...@yahoo-inc.com>.

> On 2012-05-02 18:52:29, Mona Chitnis wrote:
> > Can the testcase include a check against error code E0604 for the coord action having stale reference?

As the code is executed in runnable's run() which doesn't throw an exception, it doesn't seem possible


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4970/#review7481
-----------------------------------------------------------


On 2012-05-02 17:55:13, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4970/
> -----------------------------------------------------------
> 
> (Updated 2012-05-02 17:55:13)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-827
> 
> Patch for 3.2 and trunk
> 
> 
> This addresses bug oozie-827.
>     https://issues.apache.org/jira/browse/oozie-827
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1332945 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1332945 
> 
> Diff: https://reviews.apache.org/r/4970/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Virag
> 
>


Re: Review Request: oozie-827: StatusTransitService fails to run if a stale reference to coord job is present

Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4970/#review7481
-----------------------------------------------------------


Can the testcase include a check against error code E0604 for the coord action having stale reference?

- Mona


On 2012-05-02 17:55:13, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4970/
> -----------------------------------------------------------
> 
> (Updated 2012-05-02 17:55:13)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-827
> 
> Patch for 3.2 and trunk
> 
> 
> This addresses bug oozie-827.
>     https://issues.apache.org/jira/browse/oozie-827
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1332945 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1332945 
> 
> Diff: https://reviews.apache.org/r/4970/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Virag
> 
>


Re: Review Request: oozie-827: StatusTransitService fails to run if a stale reference to coord job is present

Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4970/#review7496
-----------------------------------------------------------

Ship it!


- Alejandro


On 2012-05-02 17:55:13, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4970/
> -----------------------------------------------------------
> 
> (Updated 2012-05-02 17:55:13)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-827
> 
> Patch for 3.2 and trunk
> 
> 
> This addresses bug oozie-827.
>     https://issues.apache.org/jira/browse/oozie-827
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1332945 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1332945 
> 
> Diff: https://reviews.apache.org/r/4970/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Virag
> 
>