You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/04/16 16:26:42 UTC
Review Request: CLOUDSTACK-741: Granular Global Parameters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
Description
-------
CLOUDSTACK-741: Granular Global Parameters
Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
Currently submitted the patch for the zone level parameter use.external.dns.
Included unit tests and marvin tests.
This addresses bug CLOUDSTACK-741.
Diffs
-----
api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
server/src/com/cloud/configuration/Config.java e69ea19
server/src/com/cloud/configuration/ConfigurationManager.java d7faf19
server/src/com/cloud/configuration/ConfigurationManagerImpl.java c9ae854
server/src/com/cloud/configuration/ConfigurationParameterScope.java PRE-CREATION
server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
server/src/com/cloud/server/ConfigurationServer.java f441b1f
server/src/com/cloud/server/ConfigurationServerImpl.java 852c00b
server/src/com/cloud/server/ManagementServerImpl.java 5ed0c92
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java a03e361
test/integration/smoke/test_UpdateCfg.py PRE-CREATION
Diff: https://reviews.apache.org/r/10548/diff/
Testing
-------
Tested locally
- tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
- tested the modified parameter to take the updated value at zone level(after updation).
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On April 16, 2013, 3:12 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 342
> > <https://reviews.apache.org/r/10548/diff/1/?file=281566#file281566line342>
> >
> > So this is available only at zone level and not at the global level is it ?
By default every parameter is at global, we specify only if there are additional scopes.
> On April 16, 2013, 3:12 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 432
> > <https://reviews.apache.org/r/10548/diff/1/?file=281566#file281566line432>
> >
> > Do u need this ?
Yes, to put back the new list in the map.
> On April 16, 2013, 3:12 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/ConfigurationParameterScope.java, line 18
> > <https://reviews.apache.org/r/10548/diff/1/?file=281569#file281569line18>
> >
> > Can we not add this in Configuration interface itself ?
Added in the config file where we create group of parameters at each level using this enum.
> On April 16, 2013, 3:12 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/server/ConfigurationServerImpl.java, line 689
> > <https://reviews.apache.org/r/10548/diff/1/?file=281573#file281573line689>
> >
> > I would like to see a clean switch statement here...
Currently this patch support zone level parameter, so 'll add switch case when I put other parameters at different levels(cluster/pool/account)
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19248
-----------------------------------------------------------
On April 17, 2013, 11:09 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 11:09 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java 852c00b
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19248
-----------------------------------------------------------
The response Class needs a change too ?
server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/10548/#comment39865>
So this is available only at zone level and not at the global level is it ?
server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/10548/#comment39867>
Lets call it ScopeLevelConfigsMap
server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/10548/#comment39866>
An English comment as to what u are trying to do would help
server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/10548/#comment39868>
Do u need this ?
server/src/com/cloud/configuration/ConfigurationParameterScope.java
<https://reviews.apache.org/r/10548/#comment39869>
Can we not add this in Configuration interface itself ?
server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/10548/#comment39870>
I would like to see a clean switch statement here...
- Nitin Mehta
On April 16, 2013, 2:26 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 2:26 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> server/src/com/cloud/configuration/Config.java e69ea19
> server/src/com/cloud/configuration/ConfigurationManager.java d7faf19
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java c9ae854
> server/src/com/cloud/configuration/ConfigurationParameterScope.java PRE-CREATION
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java 852c00b
> server/src/com/cloud/server/ManagementServerImpl.java 5ed0c92
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java a03e361
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19994
-----------------------------------------------------------
Commit 10b6c1c6c8f8c2ec49145a901fb083e7f362f3a1 in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=10b6c1c ]
CLOUDSTACK-741: Granular Global Parameters Added parameters to cluster level cluster.storage.allocated.capacity.notificationthreshold cluster.storage.capacity.notificationthreshold
CLOUDSTACK-2036
global parameter for Router Template ID functionality added
We use 5 parameters to set the router template name for each hypervisor
Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able to update/list using update/list configuration API at cluster level.
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19857
-----------------------------------------------------------
Commit deaf9106ca557a938edf25bee65cf6b4eb3ac03f in branch refs/heads/marvin_refactor from Harikrishna Patnala <ha...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=deaf910 ]
CLOUDSTACK-741: Granular Global Parameters and adding fixes for CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200
Adding the zone, cluster, account level parameters
The parameters at scope (zone/cluster/pool/account) can be updated by updateConfiguration API with additional parameter zoneid/clusterid/accountid/storagepoolid
Whenever these scoped parameters are used in CS they get value from the corresponding details table if not defined get value from global parameter.
Same with the listConfiguration API with additional parameter zoneid/clusterid/accountid/storagepoolid
- ASF Subversion and Git Services
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19437
-----------------------------------------------------------
Commit eae22d2ffaee68b5d4443cf8ab1b2dfbb339dab3 in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eae22d2 ]
CLOUDSTACK-741: Granular Global Parameters
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review20108
-----------------------------------------------------------
Commit 4a40f3f6dade062c7996611d4b8918d3fbd59d73 in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a40f3f ]
CLOUDSTACK-741: Granular Global Parameters fixing network.throttling.rate to work per zone in vmware
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Abhinandan Prateek <ap...@apache.org>.
> On April 19, 2013, 5:06 a.m., Abhinandan Prateek wrote:
> > Ship It!
This commit makes framework level changes to define scope for parameters. This will be used to actually granularize required params.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19436
-----------------------------------------------------------
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19436
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19852
-----------------------------------------------------------
Commit deaf9106ca557a938edf25bee65cf6b4eb3ac03f in branch refs/heads/master from Harikrishna Patnala <ha...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=deaf910 ]
CLOUDSTACK-741: Granular Global Parameters and adding fixes for CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200
Adding the zone, cluster, account level parameters
The parameters at scope (zone/cluster/pool/account) can be updated by updateConfiguration API with additional parameter zoneid/clusterid/accountid/storagepoolid
Whenever these scoped parameters are used in CS they get value from the corresponding details table if not defined get value from global parameter.
Same with the listConfiguration API with additional parameter zoneid/clusterid/accountid/storagepoolid
- ASF Subversion and Git Services
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review20001
-----------------------------------------------------------
Commit 807ad0a39ab272a4af2de3156b0b367570acccea in branch refs/heads/master from Nitin Mehta <ni...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=807ad0a ]
CLOUDSTACK-741 - Making storage disable thresholds configurable at zone level.
- ASF Subversion and Git Services
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review20026
-----------------------------------------------------------
Commit 807ad0a39ab272a4af2de3156b0b367570acccea in branch refs/heads/internallb from Nitin Mehta <ni...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=807ad0a ]
CLOUDSTACK-741 - Making storage disable thresholds configurable at zone level.
- ASF Subversion and Git Services
On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 4:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/
-----------------------------------------------------------
(Updated April 19, 2013, 4:07 a.m.)
Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
Description
-------
CLOUDSTACK-741: Granular Global Parameters
Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
Currently submitted the patch for the zone level parameter use.external.dns.
Included unit tests and marvin tests.
This addresses bug CLOUDSTACK-741.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
server/src/com/cloud/configuration/Config.java 2993966
server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
server/src/com/cloud/server/ConfigurationServer.java f441b1f
server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
server/src/com/cloud/server/ManagementServerImpl.java 98f789a
server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
test/integration/smoke/test_UpdateCfg.py PRE-CREATION
Diff: https://reviews.apache.org/r/10548/diff/
Testing
-------
Tested locally
- tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
- tested the modified parameter to take the updated value at zone level(after updation).
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/
-----------------------------------------------------------
(Updated April 18, 2013, 8:16 p.m.)
Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
Changes
-------
updated patch with suggested changes
Description
-------
CLOUDSTACK-741: Granular Global Parameters
Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
Currently submitted the patch for the zone level parameter use.external.dns.
Included unit tests and marvin tests.
This addresses bug CLOUDSTACK-741.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670
server/src/com/cloud/configuration/Config.java 2993966
server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
server/src/com/cloud/server/ConfigurationServer.java f441b1f
server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab
server/src/com/cloud/server/ManagementServerImpl.java 98f789a
server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
test/integration/smoke/test_UpdateCfg.py PRE-CREATION
Diff: https://reviews.apache.org/r/10548/diff/
Testing
-------
Tested locally
- tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
- tested the modified parameter to take the updated value at zone level(after updation).
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19380
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java
<https://reviews.apache.org/r/10548/#comment40094>
Dont have to add the scope id ?
server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/10548/#comment40095>
This is not going to be maintainable code. So many if's...Please put the switch statement now so that in future everyone uses it
- Nitin Mehta
On April 17, 2013, 11:09 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 11:09 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-741: Granular Global Parameters
>
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
>
> Included unit tests and marvin tests.
>
>
> This addresses bug CLOUDSTACK-741.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
> api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
> api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
> api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
> server/src/com/cloud/configuration/Config.java 2993966
> server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
> server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
> server/src/com/cloud/server/ConfigurationServer.java f441b1f
> server/src/com/cloud/server/ConfigurationServerImpl.java 852c00b
> server/src/com/cloud/server/ManagementServerImpl.java 98f789a
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
> test/integration/smoke/test_UpdateCfg.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10548/diff/
>
>
> Testing
> -------
>
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/
-----------------------------------------------------------
(Updated April 17, 2013, 11:09 a.m.)
Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
Changes
-------
updated patch with suggested changes.
Description
-------
CLOUDSTACK-741: Granular Global Parameters
Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
Currently submitted the patch for the zone level parameter use.external.dns.
Included unit tests and marvin tests.
This addresses bug CLOUDSTACK-741.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2
api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
server/src/com/cloud/configuration/Config.java 2993966
server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7
server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
server/src/com/cloud/server/ConfigurationServer.java f441b1f
server/src/com/cloud/server/ConfigurationServerImpl.java 852c00b
server/src/com/cloud/server/ManagementServerImpl.java 98f789a
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815
test/integration/smoke/test_UpdateCfg.py PRE-CREATION
Diff: https://reviews.apache.org/r/10548/diff/
Testing
-------
Tested locally
- tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
- tested the modified parameter to take the updated value at zone level(after updation).
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/
-----------------------------------------------------------
(Updated April 16, 2013, 2:26 p.m.)
Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
Description
-------
CLOUDSTACK-741: Granular Global Parameters
Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
Currently submitted the patch for the zone level parameter use.external.dns.
Included unit tests and marvin tests.
This addresses bug CLOUDSTACK-741.
Diffs
-----
api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586
api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION
api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION
server/src/com/cloud/configuration/Config.java e69ea19
server/src/com/cloud/configuration/ConfigurationManager.java d7faf19
server/src/com/cloud/configuration/ConfigurationManagerImpl.java c9ae854
server/src/com/cloud/configuration/ConfigurationParameterScope.java PRE-CREATION
server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059
server/src/com/cloud/server/ConfigurationServer.java f441b1f
server/src/com/cloud/server/ConfigurationServerImpl.java 852c00b
server/src/com/cloud/server/ManagementServerImpl.java 5ed0c92
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java a03e361
test/integration/smoke/test_UpdateCfg.py PRE-CREATION
Diff: https://reviews.apache.org/r/10548/diff/
Testing
-------
Tested locally
- tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
- tested the modified parameter to take the updated value at zone level(after updation).
Thanks,
Harikrishna Patnala