You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/02/26 17:12:20 UTC
Review Request 44073: Disabled metrics endpoint rate limiting in
mesos tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-4783
https://issues.apache.org/jira/browse/MESOS-4783
Repository: mesos
Description
-------
Disabled metrics endpoint rate limiting in mesos tests.
Diffs
-----
src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9
Diff: https://reviews.apache.org/r/44073/diff/
Testing
-------
make distcheck (ubuntu 12 & 14), make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 44073: Disabled metrics endpoint rate limiting in
mesos tests.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/#review121252
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44073/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 10:28 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-4783
> https://issues.apache.org/jira/browse/MESOS-4783
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disabled metrics endpoint rate limiting in mesos tests.
>
>
> Diffs
> -----
>
> src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9
>
> Diff: https://reviews.apache.org/r/44073/diff/
>
>
> Testing
> -------
>
> make distcheck (ubuntu 12 & 14), make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 44073: Disabled metrics endpoint rate limiting in
mesos tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/#review121241
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Feb. 28, 2016, 9:28 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44073/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 9:28 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-4783
> https://issues.apache.org/jira/browse/MESOS-4783
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disabled metrics endpoint rate limiting in mesos tests.
>
>
> Diffs
> -----
>
> src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9
>
> Diff: https://reviews.apache.org/r/44073/diff/
>
>
> Testing
> -------
>
> make distcheck (ubuntu 12 & 14), make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 44073: Disabled metrics endpoint rate limiting in
mesos tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/
-----------------------------------------------------------
(Updated Feb. 28, 2016, 10:28 p.m.)
Review request for mesos.
Changes
-------
Addressed comments from Alexander, allowed to either disable rate limiting or set it.
Bugs: MESOS-4783
https://issues.apache.org/jira/browse/MESOS-4783
Repository: mesos
Description
-------
Disabled metrics endpoint rate limiting in mesos tests.
Diffs (updated)
-----
src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9
Diff: https://reviews.apache.org/r/44073/diff/
Testing
-------
make distcheck (ubuntu 12 & 14), make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 44073: Disabled metrics endpoint rate limiting in
mesos tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Feb. 26, 2016, 8:32 p.m., Alexander Rojas wrote:
> > src/tests/main.cpp, line 75
> > <https://reviews.apache.org/r/44073/diff/1/?file=1272009#file1272009line75>
> >
> > I think this is using the posix `setenv(const char*, const char*, int)`, though the boolean as last parameter makes me doubt.
> >
> > I'd recommend using our own `os::setenv(std::string, std::string, bool)`
Yes, this was using the POSIX variant, I should probably have qualified it fully. Using the matching wrapper `os::setenv` now.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/#review120938
-----------------------------------------------------------
On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44073/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 10:28 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-4783
> https://issues.apache.org/jira/browse/MESOS-4783
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disabled metrics endpoint rate limiting in mesos tests.
>
>
> Diffs
> -----
>
> src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9
>
> Diff: https://reviews.apache.org/r/44073/diff/
>
>
> Testing
> -------
>
> make distcheck (ubuntu 12 & 14), make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 44073: Disabled metrics endpoint rate limiting in
mesos tests.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/#review120938
-----------------------------------------------------------
src/tests/main.cpp (line 75)
<https://reviews.apache.org/r/44073/#comment182469>
I think this is using the posix `setenv(const char*, const char*, int)`, though the boolean as last parameter makes me doubt.
I'd recommend using our own `os::setenv(std::string, std::string, bool)`
- Alexander Rojas
On Feb. 26, 2016, 5:12 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44073/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 5:12 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-4783
> https://issues.apache.org/jira/browse/MESOS-4783
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disabled metrics endpoint rate limiting in mesos tests.
>
>
> Diffs
> -----
>
> src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9
>
> Diff: https://reviews.apache.org/r/44073/diff/
>
>
> Testing
> -------
>
> make distcheck (ubuntu 12 & 14), make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>