You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/05 17:44:59 UTC

[jira] [Commented] (NIFI-3275) SocketChannelSender wrong message about setting the Socket Send Buffer

    [ https://issues.apache.org/jira/browse/NIFI-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802002#comment-15802002 ] 

ASF GitHub Bot commented on NIFI-3275:
--------------------------------------

GitHub user gresockj opened a pull request:

    https://github.com/apache/nifi/pull/1398

    NIFI-3275: Correcting SocketChannelSender log warning message

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gresockj/nifi NIFI-3275

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1398
    
----
commit 036aa9e0358291256f6d0b810d9b0b116d43322c
Author: Joe Gresock <jo...@lmco.com>
Date:   2017-01-05T17:41:31Z

    NIFI-3275: Correcting SocketChannelSender log warning message

----


> SocketChannelSender wrong message about setting the Socket Send Buffer
> ----------------------------------------------------------------------
>
>                 Key: NIFI-3275
>                 URL: https://issues.apache.org/jira/browse/NIFI-3275
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 0.6.0, 0.7.0, 0.6.1, 1.1.0, 0.7.1, 1.1.1, 1.0.1
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Trivial
>             Fix For: 1.2.0
>
>
> SocketChannelSender can produce the following warning message:
> {code}
> logger.warn("Attempted to set Socket Send Buffer Size to " + maxSendBufferSize
> + " bytes but could only set to " + actualSendBufSize + "bytes. You may want to "
> + "consider changing the Operating System's maximum receive buffer");
> {code}
> The last line says "receive buffer" and should be "send buffer".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)