You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/03 23:58:24 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request #31463: [WIP] Fix docstring of join
xinrong-databricks opened a new pull request #31463:
URL: https://github.com/apache/spark/pull/31463
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
Fix docstring of PySpark `DataFrame.join`.
### Why are the changes needed?
For a better view of PySpark documentation.
### Does this PR introduce _any_ user-facing change?
No (only documentation changes).
### How was this patch tested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773755685
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134900/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31463: [PYTHON][MINOR] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-772912593
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-775315609
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773752115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773752704
**[Test build #134900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134900/testReport)** for PR 31463 at commit [`08dcbd1`](https://github.com/apache/spark/commit/08dcbd1dc915679e998e16e89166b60fb6ae004a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-774491404
Merged to master/3.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31463: [PYTHON][MINOR] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773700214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31463: [WIP] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773356694
Seems fine - are there other instances?
You can mark it as non-WIP / not draft.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773752115
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39484/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773743657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773743657
**[Test build #134900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134900/testReport)** for PR 31463 at commit [`08dcbd1`](https://github.com/apache/spark/commit/08dcbd1dc915679e998e16e89166b60fb6ae004a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773743657
**[Test build #134900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134900/testReport)** for PR 31463 at commit [`08dcbd1`](https://github.com/apache/spark/commit/08dcbd1dc915679e998e16e89166b60fb6ae004a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31463: [PYTHON][MINOR] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773700214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #31463: [PYTHON][MINOR] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773712671
Thank you for your reviews!
@srowen I don't see other instances so far. I've marked the PR as non-draft.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #31463: [PYTHON][MINOR] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773712671
Thank you for your reviews!
@srowen I don't see other instances so far. I've marked the PR as non-draft.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773755685
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134900/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31463: [PYTHON][MINOR] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-772912593
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773752115
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39484/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31463: [WIP] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773356694
Seems fine - are there other instances?
You can mark it as non-WIP / not draft.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-773743657
**[Test build #134900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134900/testReport)** for PR 31463 at commit [`08dcbd1`](https://github.com/apache/spark/commit/08dcbd1dc915679e998e16e89166b60fb6ae004a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31463: [WIP] Fix docstring of join
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31463:
URL: https://github.com/apache/spark/pull/31463#issuecomment-772912593
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #31463: [PYTHON][MINOR] Fix docstring of DataFrame.join
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #31463:
URL: https://github.com/apache/spark/pull/31463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org