[GitHub] [tez] yingdachen commented on a change in pull request #41: TEZ-4062. Speculative attempt scheduling should be aborted when Task has completed.

[GitBox <gi...@apache.org>]

yingdachen commented on a change in pull request #41: TEZ-4062. Speculative attempt scheduling should be aborted when Task has completed.
URL: https://github.com/apache/tez/pull/41#discussion_r277209022
 
 

 ##########
 File path: tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestTaskImpl.java
 ##########
 @@ -982,6 +982,23 @@ public void testSpeculatedThenRetroactiveFailure() {
     Assert.assertEquals(mockDestId, newAttempt.getSchedulingCausalTA());
   }
 
+  @Test(timeout = 20000)
+  public void testIgnoreSpeculation() {
+    TezTaskID taskId = getNewTaskID();
+    scheduleTaskAttempt(taskId);
+    MockTaskAttemptImpl firstAttempt = mockTask.getLastAttempt();
+    launchTaskAttempt(firstAttempt.getID());
+    // Have the first task succeed
 
 Review comment:
   mock success of the first task attempt

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services