[jira] [Commented] (AIRFLOW-6704) TaskInstance.operator is not set when task is marked success or failed in the Web UI

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028115#comment-17028115 ] 

ASF GitHub Bot commented on AIRFLOW-6704:
-----------------------------------------

yuqian90 commented on pull request #7324: [AIRFLOW-6704] Set TaskInstance.operator in constructor
URL: https://github.com/apache/airflow/pull/7324
 
 
   ``TaskInstance.operator`` is currently only set when task is executed. But if a task is marked success or failed, the ``operator`` field is left as None.
   
   This causes bugs when some other code tries to use the ``operator`` field to find the name of the class.
   
   The fix is trivial, just set ``TaskInstance.operator`` in its constructor.
   
   An assertion is also added in ``test_mark_tasks.py`` to test this.
   
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> TaskInstance.operator is not set when task is marked success or failed in the Web UI
> ------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6704
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6704
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: models
>    Affects Versions: 1.10.7
>            Reporter: Qian Yu
>            Assignee: Qian Yu
>            Priority: Major
>
> {{TaskInstance.operator}} is currently only set when task is executed. But if a task is marked success or failed, the {{operator}} field is left as {{None}}.
> This causes bugs when some code tries to use the operator field to find the name of the class.
> The fix is trivial, just set {{TaskInstance.operator}} in its constructor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)