You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Jun Zhang (Jira)" <ji...@apache.org> on 2020/02/07 23:36:00 UTC
[jira] [Created] (OAK-8896) API withDomainOverrideIgnored doesn't
match the implementation of BinaryUploadOptions
Jun Zhang created OAK-8896:
------------------------------
Summary: API withDomainOverrideIgnored doesn't match the implementation of BinaryUploadOptions
Key: OAK-8896
URL: https://issues.apache.org/jira/browse/OAK-8896
Project: Jackrabbit Oak
Issue Type: Bug
Components: api
Affects Versions: 1.24.0
Reporter: Jun Zhang
the new API withDomainOverrideIgnored though, it's named as {{withDomainOverrideIgnored}} for both BinaryDownloadOptions and BinaryUploadOptions per documentation, but it's `{{withDomainOverrideIgnore}}` in the implementation of BinaryUploadOptions class, it missed a ending {{d}} in the method name for BinaryUploadOptions,
The document is wrong ATM and the API name doesn't match with each other, making change over that or just leave with it and fix the document?
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUploadOptions.java#L96] [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryDownloadOptions.java#L325]Doc:
[https://jackrabbit.apache.org/oak/docs/features/direct-binary-access.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)