You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@otava.apache.org by "Gerrrr (via GitHub)" <gi...@apache.org> on 2026/01/31 20:18:56 UTC
[PR] Feat/118 [otava]
Gerrrr opened a new pull request, #124:
URL: https://github.com/apache/otava/pull/124
This PR contains my understanding of what we want to achieve in https://github.com/apache/otava/issues/118.
Changes:
- `regressions` command is removed as a Datastax-specific thing. `analyze` covers all interesting use cases.
- `analyze --branch` is ConfigArgParsified and can be configured via `BRANCH` env variable.
- Configuration syntax for `analyze --branch` is unified as much as possible across importers. As a standard, I used Graphite `%BRANCH` syntax. It is reused it in Postgres and BigQuery importers plus. Csv importer has its own thing. It looks at a `branch` column and behaves in the following way:
1. If there is no branch column and `--branch` is not specified, it works as before.
2. If there is a branch column and `--branch` is not specified, the importer checks that that column contains a unique value a guardrail against mixing results between different branches.
3. If there is a branch column and `--branch` is specified, the importer will filter out values for rows where the value in branch column is not equal to the passed value.
4. If there is no branch column and `--branch` is specified, the importer throws.
- There is no default value for `--branch` now and a test config has at least one `%BRANCH`, a user must pass it.
- %{BRANCH} is escaped against SQL injections in PostgreSQL and BigQuery, just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat/118 [otava]
Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr commented on PR #124:
URL: https://github.com/apache/otava/pull/124#issuecomment-3949282532
On a slightly different topic, after the conversation in https://github.com/apache/otava/pull/127 I am having second thoughts about only doing string replacement with `--branch` and not addressing "A/B" testing in Otava CLI in any way. I will share an idea in https://github.com/apache/otava/issues/118 in order not to block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat/118 [otava]
Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr commented on PR #124:
URL: https://github.com/apache/otava/pull/124#issuecomment-3863379474
Bump @henrikingo :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat/118 [otava]
Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr commented on PR #124:
URL: https://github.com/apache/otava/pull/124#issuecomment-3912413390
> This aspect of the code deserves a serious refactoring.
+1, I plan to refactor the importer code soon as a step towards https://github.com/apache/otava/issues/55.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat/118 [otava]
Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr commented on PR #124:
URL: https://github.com/apache/otava/pull/124#issuecomment-3949275724
> What's the difference between --branch and --attrs branch
`--attrs` only works with `GraphiteImporter`. Also, `attrs` does not allow you to overwrite a parameter from CLI - it just filters out attributes that are not explicitly specified - https://github.com/apache/otava/blob/2bb687f76ddbe36191263524d0f179d8838404ed/otava/importer.py#L163-L181.
Additionally, this attribute list is Fallout-specific with `run_id` and `version` there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat/118 [otava]
Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr merged PR #124:
URL: https://github.com/apache/otava/pull/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org