You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2009/06/24 11:23:40 UTC
svn commit: r787955 - /tomcat/current/tc5.5.x/STATUS.txt
Author: kkolinko
Date: Wed Jun 24 09:23:37 2009
New Revision: 787955
URL: http://svn.apache.org/viewvc?rev=787955&view=rev
Log:
Updated patch. See bugzilla for details. I think that Mark won't mind.
Added my vote.
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=787955&r1=787954&r2=787955&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jun 24 09:23:37 2009
@@ -125,10 +125,11 @@
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37084
- https://issues.apache.org/bugzilla/attachment.cgi?id=23860
+ https://issues.apache.org/bugzilla/attachment.cgi?id=23861
Port of fix for 46471 that also fixes this JspC compilation issue
- +1: markt
+ +1: markt, kkolinko
-1:
+ kkolinko: attachment.cgi?id=23860 had a bug, 23861 should be used instead.
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37794
Handle chunked POSTs. If maxPostSize is exceeded, a 500 results
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r787955 - /tomcat/current/tc5.5.x/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
Konstantin Kolinko wrote:
> 2009/6/24 Mark Thomas <ma...@apache.org>:
>> kkolinko@apache.org wrote:
>>> Author: kkolinko
>>> Date: Wed Jun 24 09:23:37 2009
>>> New Revision: 787955
>>>
>>> URL: http://svn.apache.org/viewvc?rev=787955&view=rev
>>> Log:
>>> Updated patch. See bugzilla for details. I think that Mark won't mind.
>> I don't mind although I am a little confused. The only change I can see
>> has also been proposed for backport in this commit:
>> http://svn.apache.org/viewvc?rev=787986&view=rev
>>
>> What am I missing?
>>
>
> In the old patch there is
> + rctxt.getWrapper(tagFileJarPath +tagFilePath);
>
> and few lines later:
> + rctxt.addWrapper(tagFileJarUrl + tagFilePath, wrapper);
>
> The first call uses tagFileJarPath while the second one uses tagFileJarUrl.
Thanks. All makes sense now.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r787955 - /tomcat/current/tc5.5.x/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2009/6/24 Mark Thomas <ma...@apache.org>:
> kkolinko@apache.org wrote:
>> Author: kkolinko
>> Date: Wed Jun 24 09:23:37 2009
>> New Revision: 787955
>>
>> URL: http://svn.apache.org/viewvc?rev=787955&view=rev
>> Log:
>> Updated patch. See bugzilla for details. I think that Mark won't mind.
>
> I don't mind although I am a little confused. The only change I can see
> has also been proposed for backport in this commit:
> http://svn.apache.org/viewvc?rev=787986&view=rev
>
> What am I missing?
>
In the old patch there is
+ rctxt.getWrapper(tagFileJarPath +tagFilePath);
and few lines later:
+ rctxt.addWrapper(tagFileJarUrl + tagFilePath, wrapper);
The first call uses tagFileJarPath while the second one uses tagFileJarUrl.
I found this when comparing your patch against
http://svn.apache.org/viewvc?rev=739530&view=rev
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r787955 - /tomcat/current/tc5.5.x/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
kkolinko@apache.org wrote:
> Author: kkolinko
> Date: Wed Jun 24 09:23:37 2009
> New Revision: 787955
>
> URL: http://svn.apache.org/viewvc?rev=787955&view=rev
> Log:
> Updated patch. See bugzilla for details. I think that Mark won't mind.
I don't mind although I am a little confused. The only change I can see
has also been proposed for backport in this commit:
http://svn.apache.org/viewvc?rev=787986&view=rev
What am I missing?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org