You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Jasper Rosenberg (JIRA)" <ji...@apache.org> on 2009/07/14 17:52:58 UTC
[jira] Created: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Add tbody tags around xhtml theme form table to enclose any hidden elements
---------------------------------------------------------------------------
Key: WW-3190
URL: https://issues.apache.org/struts/browse/WW-3190
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.1.6
Reporter: Jasper Rosenberg
Priority: Minor
Fix For: 2.1.8
For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46481#action_46481 ]
Dave Newton commented on WW-3190:
---------------------------------
IIRC this is either a dupe or has already been fixed.
Although now that I think about it maybe it was just something on the user list that I had happened to notice at the same time.
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Jasper Rosenberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasper Rosenberg reopened WW-3190:
----------------------------------
I agree that facebook is not a good enough reason to address this issue, but I think the larger issue is something that at some point should be fixed, which is that hidden fields in the xhtml theme won't pass http://validator.w3.org/check (even with the tbody addition). Really these hidden fields need to be moved outside the table to be directly in the form and that, unfortunately, is much trickier to fix...
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Jasper Rosenberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46487#action_46487 ]
Jasper Rosenberg commented on WW-3190:
--------------------------------------
Yeah that looks like the same issue with a different suggested solution. Not sure if just adding tbody would solve the html warnings, but would be great if it did as I'd rather not add rows for each hidden input (particularly since I think it wouldn't always be colspan="2", though I can't remember if that is a general case for labelposition="top" or something I added to my local theme...)
Thanks for looking into it!
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-3190) Add tbody tags around xhtml
theme form table to enclose any hidden elements
Posted by "Jasper Rosenberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46483#action_46483 ]
Jasper Rosenberg edited comment on WW-3190 at 7/14/09 6:19 PM:
---------------------------------------------------------------
A quick search of the JIRA for "tbody" didn't show any dupes...
was (Author: perfnorm):
I quick search of the JIRA for "tbody" didn't show any dupes...
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46632#action_46632 ]
Musachy Barroso commented on WW-3190:
-------------------------------------
To be honest I am not sure changing this just to make facebook happy is a good idea. This will break a lot of test, and might even have some impact in the javascript validation(which is very fragile). I would be more worried if there was no work around, but overwriting the templates is an option.
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46486#action_46486 ]
Dave Newton commented on WW-3190:
---------------------------------
Ah; found it:
http://www.nabble.com/HTML-warnings-for-%3Chidden%3E-in-xhtml-theme-td22954508.html
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes Wannemacher updated WW-3190:
--------------------------------
Fix Version/s: (was: 2.1.8)
2.1.9
if we do this, there will be many tests that need updated and I'd rather see this go in at the start of a release's iteration so that the change can see plenty of testing by SNAPSHOT users (not right before a release)
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.9
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46485#action_46485 ]
Dave Newton commented on WW-3190:
---------------------------------
I can't find it in the newsgroup either, but I know it came up not too long before I went on vacation, so probably June.
Either way, it'll get looked into.
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso resolved WW-3190.
---------------------------------
Resolution: Won't Fix
see comments
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-3190) Add tbody tags around xhtml theme form
table to enclose any hidden elements
Posted by "Jasper Rosenberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46483#action_46483 ]
Jasper Rosenberg commented on WW-3190:
--------------------------------------
I quick search of the JIRA for "tbody" didn't show any dupes...
> Add tbody tags around xhtml theme form table to enclose any hidden elements
> ---------------------------------------------------------------------------
>
> Key: WW-3190
> URL: https://issues.apache.org/struts/browse/WW-3190
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.6
> Reporter: Jasper Rosenberg
> Priority: Minor
> Fix For: 2.1.8
>
>
> For whatever reason, with "Quickling" enabled facebook's html parsing barfs if there are hidden inputs directly within a table. However, if you add the tbody tags it works fine. This is easy enough to fix just by adding <tbody> to the end of control.ftl and </tbody> to the start of control-close.ftl
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.