You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2015/05/04 03:54:06 UTC

[jira] [Commented] (HADOOP-11906) test-patch.sh should use 'file' command for patch determinism

    [ https://issues.apache.org/jira/browse/HADOOP-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526156#comment-14526156 ] 

Allen Wittenauer commented on HADOOP-11906:
-------------------------------------------

Some notes here.  If a file doesn't end in .patch, then we should assume the person is a new or confused contributor and give them some pointers for help:

* Part of HADOOP-11906 should probably be a -mild scolding- pointer to the naming standard for patches
* The branch detection rules should be disabled

> test-patch.sh should use 'file' command for patch determinism
> -------------------------------------------------------------
>
>                 Key: HADOOP-11906
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11906
>             Project: Hadoop Common
>          Issue Type: Test
>            Reporter: Allen Wittenauer
>
> test-patch.sh currently restricts patches to the extension .patch.  It might be useful to also check if the file command says it is a diff.  This would allow us to determine if files that end in .txt are actually patches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)