[GitHub] [incubator-superset] rusackas commented on a change in pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #9086: [dashboard, chart] fix, add filter support to match FAB's filter functionality 
URL: https://github.com/apache/incubator-superset/pull/9086#discussion_r382737475
 
 

 ##########
 File path: superset-frontend/src/components/ListView/ListView.tsx
 ##########
 @@ -28,11 +28,15 @@ import {
   Row,
   // @ts-ignore
 } from 'react-bootstrap';
+// @ts-ignore
+import { default as SelectComponent } from 'react-select';
 
 Review comment:
   silly NIT/question - just wondering why you chose this over `import SelectComponent from 'react-select';`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org