You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "KamranImaaz (via GitHub)" <gi...@apache.org> on 2026/01/27 14:26:07 UTC
[PR] remove operators redundant exception handling [airflow]
KamranImaaz opened a new pull request, #61124:
URL: https://github.com/apache/airflow/pull/61124
Fixes #60687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3827835658
Thanks Shahar for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3831378871
> get_cluster_states_for_table
> Shahar I have one suggestion. In Bigtable Hooks currently we are having this `get_cluster_states_for_table` (it fetches the clusters associated with a particular table) but which is currently not used by any Operator.
>
> For `BigtableCreateTableOperator`, since clusters are created by default while creating a table, would it make sense to reuse this hook method and log the number (and possibly state) of clusters associated with the table after creation?
>
> Whats your view in this??
It's being used in the `BigtableTableReplicationCompletedSensor` sensor.
I don't think it makes sense to be used in `BigtableCreateTableOperator`, as clusters are not created by default (you run `hook.get_instance()` to get them, they are not auto-provisioned).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3806956530
> instance = hook.get_instance(project_id=self.project_id, instance_id=self.instance_id)
You may encapsulate it in the hook where applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3806965452
Okay Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3806882444
And Also Shahar this we are using everywhere in the operator instead of that we can use `instance.exists()` in one line in hooks right??
```
instance = hook.get_instance(project_id=self.project_id, instance_id=self.instance_id)
if not instance:
raise AirflowException(f"Dependency: instance '{self.instance_id}' does not exist.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3828584746
There are many open GCP issues(some are very older that i don't know whether they are relevant or not). If you don't mind can you assign me any of those issues. I would be happy to work on those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3878870483
Ran it myself eventually, we're good to go:
<img width="847" height="502" alt="image" src="https://github.com/user-attachments/assets/f9629245-9dfd-431c-a406-efdfb14854a4" />
@KamranImaaz - Great job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3827845206
> I created an issue for that yesterday inorder to get your approval before opening a PR. Please have a look #61269
I wasn't talking about the documentation in `bigtable.rst` (which indeed should be updated), but the docstring which is part of the method.
Take a look at: https://github.com/KamranImaaz/apache.airflow/blob/79fb50b12d738f75f25f29717b92a16b75cb22dc/providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py#L245
After your changes this won't be true anymore (same goes for strings in the other methods).
I hope that it's clearer now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3830407755
> @shahar1 All Checks have passed!
Great! I'll give Google's team a couple of more days to comment, and then I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3828567286
> > I created an issue for that yesterday inorder to get your approval before opening a PR. Please have a look #61269
>
> I wasn't talking about the documentation in `bigtable.rst` (which indeed should be updated), but the docstring which is part of the method. Take a look at: https://github.com/KamranImaaz/apache.airflow/blob/79fb50b12d738f75f25f29717b92a16b75cb22dc/providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py#L245
>
> After your changes this won't be true anymore (same goes for strings in the other methods). I hope that it's clearer now.
Done Shahar Updated the docstrings. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3813869273
I have updated the code according to your comments. Please have a view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3828578914
> Excellent job Kamran!
>
> CC: @VladaZakharova @MaksYermak
Thanks Shahar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3827836720
I created an issue for that yesterday inorder to get your approval before opening a PR. Please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove operators redundant exception handling [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on code in PR #61124:
URL: https://github.com/apache/airflow/pull/61124#discussion_r2733347668
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py:
##########
@@ -268,7 +273,12 @@ def update_cluster(instance: Instance, cluster_id: str, nodes: int) -> None:
"""
cluster = Cluster(cluster_id, instance)
# "reload" is required to set location_id attribute on cluster.
- cluster.reload()
+ try:
+ cluster.reload()
+ except google.api_core.exceptions.NotFound:
+ raise AirflowException(
+ f"Dependency: cluster '{cluster_id}' does not exist for instance '{instance_id}'."
+ )
Review Comment:
Okay Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3834700710
Following a recent incident - I want also to ensure that related system tests pass before merging this one.
@KamranImaaz - if you're able to run them, please go ahead and attach screenshots. Otherwise, we'll have to wait for either Google team or anyone else to run them.
CC: @VladaZakharova @KamranImaaz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3827849591
Oh Okay. I misunderstood it. Now I get it. I will update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3828643394
> > There are many open GCP issues(some are very older that i don't know whether they are relevant or not). If you don't mind can you assign me any of those issues. I would be happy to work on those.
>
> Sounds good, please tag me in a couple of issues and I'll assign you if they are still relevant.
Sure I will tag you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3828640405
Static checks seems to fail, could you please run the pre-commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove operators redundant exception handling [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #61124:
URL: https://github.com/apache/airflow/pull/61124#discussion_r2733329905
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py:
##########
@@ -252,11 +253,15 @@ def delete_table(self, instance_id: str, table_id: str, project_id: str) -> None
instance = self.get_instance(instance_id=instance_id, project_id=project_id)
if instance is None:
raise RuntimeError(f"Instance {instance_id} did not exist; unable to delete table {table_id}")
+
table = instance.table(table_id=table_id)
- table.delete()
+ try:
+ table.delete()
+ except google.api_core.exceptions.NotFound:
+ self.log.info("The table '%s' no longer exists. Consider it as deleted", table_id)
Review Comment:
Please add unit tests (you could use the tests you just deleted from the operator)
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py:
##########
@@ -252,11 +253,15 @@ def delete_table(self, instance_id: str, table_id: str, project_id: str) -> None
instance = self.get_instance(instance_id=instance_id, project_id=project_id)
if instance is None:
raise RuntimeError(f"Instance {instance_id} did not exist; unable to delete table {table_id}")
+
table = instance.table(table_id=table_id)
- table.delete()
+ try:
+ table.delete()
+ except google.api_core.exceptions.NotFound:
+ self.log.info("The table '%s' no longer exists. Consider it as deleted", table_id)
@staticmethod
- def update_cluster(instance: Instance, cluster_id: str, nodes: int) -> None:
+ def update_cluster(instance: Instance, instance_id: str, cluster_id: str, nodes: int) -> None:
Review Comment:
Adding a required parameter here is a breaking change.
You should be able to fetch the id from the `instance` parameter.
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py:
##########
@@ -268,7 +273,12 @@ def update_cluster(instance: Instance, cluster_id: str, nodes: int) -> None:
"""
cluster = Cluster(cluster_id, instance)
# "reload" is required to set location_id attribute on cluster.
- cluster.reload()
+ try:
+ cluster.reload()
+ except google.api_core.exceptions.NotFound:
+ raise AirflowException(
+ f"Dependency: cluster '{cluster_id}' does not exist for instance '{instance_id}'."
+ )
Review Comment:
1. I'll waive the usage of `AirflowException` here because it was relocated from the operator, but eventually we'll need to deprecate it.
2. If you relocate the logic - it should be tested (you could use the deleted tests from the operator as a reference)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove operators redundant exception handling [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on code in PR #61124:
URL: https://github.com/apache/airflow/pull/61124#discussion_r2733345591
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py:
##########
@@ -252,11 +253,15 @@ def delete_table(self, instance_id: str, table_id: str, project_id: str) -> None
instance = self.get_instance(instance_id=instance_id, project_id=project_id)
if instance is None:
raise RuntimeError(f"Instance {instance_id} did not exist; unable to delete table {table_id}")
+
table = instance.table(table_id=table_id)
- table.delete()
+ try:
+ table.delete()
+ except google.api_core.exceptions.NotFound:
+ self.log.info("The table '%s' no longer exists. Consider it as deleted", table_id)
Review Comment:
Sure I will add the unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3828639701
> There are many open GCP issues(some are very older that i don't know whether they are relevant or not). If you don't mind can you assign me any of those issues. I would be happy to work on those.
Sounds good, please tag me in a couple of issues and I'll assign you if they are still relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3830511757
Shahar I have one suggestion. In Bigtable Hooks currently we are having this `get_cluster_states_for_table` (it fetches the clusters associated with a particular table) but which is currently not used by any Operator.
For `BigtableCreateTableOperator`, since clusters are created by default while creating a tab;e, would it make sense to reuse this hook method and log the number (and possibly state) of clusters associated with the table after creation?
Whats your view in this??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3859123026
> LGTM
Just to make it clear - are you ok with merging without running the system tests?
Personally I don't find anything that could be broken in the system tests due to the suggested changes, but it was @VladaZakharova 's request - so I want to ensure that we're all aligned.
If you are able to run it on your side before merging it would be the best, so we could avoid unnecessary reverts later on.
I'm also still waiting to chat with your team regarding the integration of Google provider system tests in the CI.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove operators redundant exception handling [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on code in PR #61124:
URL: https://github.com/apache/airflow/pull/61124#discussion_r2733339932
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigtable.py:
##########
@@ -252,11 +253,15 @@ def delete_table(self, instance_id: str, table_id: str, project_id: str) -> None
instance = self.get_instance(instance_id=instance_id, project_id=project_id)
if instance is None:
raise RuntimeError(f"Instance {instance_id} did not exist; unable to delete table {table_id}")
+
table = instance.table(table_id=table_id)
- table.delete()
+ try:
+ table.delete()
+ except google.api_core.exceptions.NotFound:
+ self.log.info("The table '%s' no longer exists. Consider it as deleted", table_id)
@staticmethod
- def update_cluster(instance: Instance, cluster_id: str, nodes: int) -> None:
+ def update_cluster(instance: Instance, instance_id: str, cluster_id: str, nodes: int) -> None:
Review Comment:
Okay sure Shahar I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove operators redundant exception handling [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3805537221
@shahar1 due to a small mistake i accidentally pushed the all commits and got auto assigned reviewers. Sorry for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3830402709
@shahar1 All Checks have passed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3825551739
@shahar1 all the CI checks have passed. your approval would be great here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3827854776
BTW, I already created a branch and was working on it for #61269 seems it already got assigned. Never mind. Let the other person do the work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize exception handling in GCP bigtable operator and hook [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3836635851
> Following a recent incident - I want also to ensure that related system tests pass before merging this one. @KamranImaaz - if you're able to run them, please go ahead and attach screenshots. Otherwise, we'll have to wait for either Google team or anyone else to run them.
>
> CC: @VladaZakharova @KamranImaaz
Hi @shahar1 while I currently do not have the access to run the system tests. I will try to get the access and run them. In the meanwhile google team can run them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move exception handling from Google Bigtable operators to hooks [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #61124:
URL: https://github.com/apache/airflow/pull/61124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move exception handling from Google Bigtable operators to hooks [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61124:
URL: https://github.com/apache/airflow/pull/61124#issuecomment-3879027142
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org