[GitHub] [hudi] danny0405 commented on a diff in pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8218:
URL: https://github.com/apache/hudi/pull/8218#discussion_r1140250519


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/ExpressionEvaluators.java:
##########
@@ -255,9 +255,12 @@ public static NotEqualTo getInstance() {
 
     @Override
     protected boolean eval(@NotNull Object val, ColumnStats columnStats, LogicalType type) {
-      // because the bounds are not necessarily a min or max value, this cannot be answered using them.
-      // notEq(col, X) with (X, Y) doesn't guarantee that X is a value in col.
-      return true;

Review Comment:
    Suggest to keep this comment and add specific explanation for constant column



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org