[GitHub] flink issue #3743: [FLINK-6228][table] Integrating the OVER windows in the T...

[sunjincheng121 <gi...@git.apache.org>]

Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/3743
  
    @fhueske Thanks a lot for your comments and suggestions. And I like the idea of move all validations into `validateInput` method. I have updated the PR with following changes:
    1.Check that orderBy field is correctly validated (only rowtime, proctime)
    2.Check that partitionBy fields are correctly validated (existing fields in the input, no complex expressions)
    3.Check that preceding and following are of same type
    4.Check that preceding and following are literals
    5.Check that preceding value is > 0
    6.Check that following value is >= -1
    7.Move all validations into `validateInput` method.
    BTW. In this PR we only add batch check in the `table.scala#window(overWindows: OverWindow*)` method.
    
    Thanks,
    SunJincheng


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---