[jira] Commented: (DERBY-3211) Convert derbynet/NSinSameJVM.java to junit

["Daniel John Debrunner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543227 ] 

Daniel John Debrunner commented on DERBY-3211:
----------------------------------------------

- Are there comments as to why a different security policy file is needed? It didn't jump out at me what was different about these policy files.

- Instead of code like this you can use the utility method: JDBC.assertDrainResults()
+			while (rs.next()) {
+				rs.getString(1);
+			}
+			rs.close();

- In a test fixture (e.g. testStartAndShutdown) there's no need to catch Exception like this:
+		} catch (Exception e) {
+			System.out.print("FAIL: Unexpected exception" + e.getMessage());
+			e.printStackTrace();
+		}

Junit will report a failure if an exception is thrown from a fixture.

- In testStartAndShutdown() any idea what this comment means? Since the fixture finishes there is no test code making sure of anything so
I wonder what it's trying to sat?

+			// Leave the connection open before shutdown to make 
+			// sure the thread closes down.

testStartAndShutdown() doesn't actually start the network server, that's handled by the decorator, right? If so the description and name of the fixture is misleading.






 


> Convert derbynet/NSinSameJVM.java to junit
> ------------------------------------------
>
>                 Key: DERBY-3211
>                 URL: https://issues.apache.org/jira/browse/DERBY-3211
>             Project: Derby
>          Issue Type: Test
>            Reporter: Manjula Kutty
>            Assignee: Manjula Kutty
>            Priority: Minor
>         Attachments: DERBY-3211_diff_11_16.txt, DERBY-3211_stat_11_16.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.