[jira] [Comment Edited] (CAMEL-6775) Aggregate - Potential little optimization to send aggregated exchange to completion outside the lock

["Baris Acar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-6775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775690#comment-13775690 ] 

Baris Acar edited comment on CAMEL-6775 at 9/23/13 9:51 PM:
------------------------------------------------------------

Claus,
I see you've modified the test to add a timeout but this causes the test to pass (after 5 seconds) even on Camel 2.11, which I think defeats the purpose of the test? (The test as it stands does not demonstrate that the behaviour has been fixed).

You may want to change
{code}
    latch.await(5, TimeUnit.SECONDS);
{code}
to
{code}
    if(!latch.await(5, TimeUnit.SECONDS)) {
    	throw new RuntimeException("Took too long; assume threads are blocked and fail test");
    }

{code}



                
      was (Author: barisacar):
    Claus,
I see you've added the test to add a timeout but this causes the test to pass (after 5 seconds) even on Camel 2.11, which I think defeats the purpose of the test? (The test as it stands does not demonstrate that the behaviour has been fixed).

You may want to change
{code}
    latch.await(5, TimeUnit.SECONDS);
{code}
to
{code}
    if(!latch.await(5, TimeUnit.SECONDS)) {
    	throw new RuntimeException("Took too long; assume threads are blocked and fail test");
    }

{code}



                  
> Aggregate - Potential little optimization to send aggregated exchange to completion outside the lock
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-6775
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6775
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core, eip
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.13.0
>
>         Attachments: AggregatorLockingTest.java
>
>
> The aggregate eip needs to aggregate logic to operation in a lock. But if there is a completed aggregated exchange we can send that exchange to the downstream thread pool outside the lock.
> See nabble
> http://camel.465427.n5.nabble.com/Aggregator-lock-tp5739692.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira