[PR] Fix transformer name normalization for catalog lookup during export [camel]

["smongiar (via GitHub)" <gi...@apache.org>]

smongiar opened a new pull request, #23780:
URL: https://github.com/apache/camel/pull/23780

   ## Summary
   
   - Normalize transformer names before catalog lookup in `DependencyDownloaderTransformerResolver`
   - Transformer names use colon-separated format (`aws2-ddb:application-json`) but the catalog stores them in dash-separated format (`aws2-ddb-application-json`)
   - The `normalize(key)` method from `TransformerResolver` interface already handles this conversion via `StringHelper.sanitize()` — it just wasn't being called before the catalog lookup
   - Also normalize the name for the "did you mean" suggestion to produce accurate suggestions
   
   ## Reproducer
   
   ```bash
   # Create a route using a kamelet with data type transformers
   cat > DdbSinkRoute.java << 'ROUTE'
   import org.apache.camel.builder.RouteBuilder;
   public class DdbSinkRoute extends RouteBuilder {
       @Override
       public void configure() {
           from("timer:tick?period=5000")
               .setBody(constant("{\"key\": \"value\"}"))
               .to("kamelet:aws-ddb-sink");
       }
   }
   ROUTE
   
   # This fails with: Cannot find transformer with name: aws2-ddb:application-json.
   # Did you mean: aws2-ddb-application-json
   camel export --runtime=spring-boot --gav=com.example:test:1.0.0 --dir=./app DdbSinkRoute.java
   ```
   
   ## Test plan
   
   - [x] Added `catalogLookupShouldNormalizeColonSeparatedNames()` test verifying catalog lookup works with colon-separated names after normalization
   - [x] Existing `stubTransformerShouldHaveNameSet()` test still passes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix transformer name normalization for catalog lookup during export [camel]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #23780:
URL: https://github.com/apache/camel/pull/23780#issuecomment-4630451205

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix transformer name normalization for catalog lookup during export [camel]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #23780:
URL: https://github.com/apache/camel/pull/23780#issuecomment-4630492706

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `dsl/camel-kamelet-main`
   
   <details><summary>All tested modules (6 modules)</summary>
   
   - Camel :: JBang :: MCP
   - Camel :: JBang :: Plugin :: Route Parser
   - Camel :: JBang :: Plugin :: TUI
   - Camel :: JBang :: Plugin :: Validate
   - Camel :: Kamelet Main
   - Camel :: Launcher :: Container
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/27006424558)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix transformer name normalization for catalog lookup during export [camel]

["davsclaus (via GitHub)" <gi...@apache.org>]

davsclaus merged PR #23780:
URL: https://github.com/apache/camel/pull/23780


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org