You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/10 08:45:05 UTC
[GitHub] [phoenix] stoty opened a new pull request #959: PHOENIX-6216 Add Omid and Tephra support to create-release script
stoty opened a new pull request #959:
URL: https://github.com/apache/phoenix/pull/959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #959: PHOENIX-6216 Add Omid and Tephra support to create-release script
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #959:
URL: https://github.com/apache/phoenix/pull/959#issuecomment-724559317
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 3m 47s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | hadolint | 0m 2s | There were no new hadolint issues. |
| -1 :x: | shellcheck | 0m 7s | The patch generated 3 new + 6 unchanged - 1 fixed = 9 total (was 7) |
| +1 :green_heart: | shelldocs | 0m 1s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 8m 46s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-959/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/959 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs |
| uname | Linux d12ac8db3a47 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 28518ff |
| shellcheck | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-959/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 52 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-959/1/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #959: PHOENIX-6216 Add Omid and Tephra support to create-release script
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #959:
URL: https://github.com/apache/phoenix/pull/959#discussion_r522813831
##########
File path: dev/create-release/phoenix-rm/Dockerfile
##########
@@ -52,6 +52,11 @@ RUN wget -qO- "https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&fi
tar xvz -C /opt
ENV YETUS_HOME /opt/apache-yetus-${YETUS_VERSION}
+# Install protobuf-2.5 protoc binary from maven central, as that seems to be the only binary available
+RUN mkdir /opt/protobuf-2.5.0
Review comment:
It doesn't make the HBase protobuf version mess any worse than it already is :)
We use unshaded 2.5 for the coprocessor api, just as in Phoenix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #959: PHOENIX-6216 Add Omid and Tephra support to create-release script
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #959:
URL: https://github.com/apache/phoenix/pull/959#discussion_r522812170
##########
File path: dev/create-release/release-util.sh
##########
@@ -636,12 +637,22 @@ function kick_gpg_agent {
# Do maven command to set version into local pom
function maven_set_version { #input: <version_to_set>
local this_version="$1"
- echo "${MVN[@]}" versions:set -DnewVersion="$this_version"
- "${MVN[@]}" versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
- #Hacking around nonstandard maven submodules
+ # Omid needs an hbase profile for tagging (doesn't matter which one, the shims need special handling anyway)
+ if [[ "$PROJECT" == "phoenix-omid" ]]; then
+ local variant="${OMID_VARIANTS[1]}"
+ fi
+ echo "${MVN[@]}" ${variant:+"$variant"} versions:set -DnewVersion="$this_version"
+ "${MVN[@]}" ${variant:+"$variant"} versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+ #Hacking around nonstandard maven submodules for phoenix only
for i in phoenix-hbase-compat-*; do
if [ -e "$i" ]; then
- "${MVN[@]}" -pl $i versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+ "${MVN[@]}" ${variant:+"$variant"} -pl $i versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+ fi
+ done
+ #Omid has an even more nonstandard maven structure, and needs more hacks
+ for i in hbase-shims/hbase-*; do
+ if [ -e "$i" ]; then
+ sed -i -e "0,\#<version>.*</version>#{s##<version>${this_version}</version>#}" $i/pom.xml
Review comment:
Long term we should fix the build to build both set of artifacts in one pass, like connectors and tephra does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #959: PHOENIX-6216 Add Omid and Tephra support to create-release script
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #959:
URL: https://github.com/apache/phoenix/pull/959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] ankitsinghal commented on a change in pull request #959: PHOENIX-6216 Add Omid and Tephra support to create-release script
Posted by GitBox <gi...@apache.org>.
ankitsinghal commented on a change in pull request #959:
URL: https://github.com/apache/phoenix/pull/959#discussion_r522733663
##########
File path: dev/create-release/phoenix-rm/Dockerfile
##########
@@ -52,6 +52,11 @@ RUN wget -qO- "https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&fi
tar xvz -C /opt
ENV YETUS_HOME /opt/apache-yetus-${YETUS_VERSION}
+# Install protobuf-2.5 protoc binary from maven central, as that seems to be the only binary available
+RUN mkdir /opt/protobuf-2.5.0
Review comment:
Not particular to this change, but I hope Omid dependency on protobuf 2.5.0 doesn't conflict with the protobuf 3.0+ in Hadoop/HBase/Phoenix runtime.
##########
File path: dev/create-release/release-util.sh
##########
@@ -636,12 +637,22 @@ function kick_gpg_agent {
# Do maven command to set version into local pom
function maven_set_version { #input: <version_to_set>
local this_version="$1"
- echo "${MVN[@]}" versions:set -DnewVersion="$this_version"
- "${MVN[@]}" versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
- #Hacking around nonstandard maven submodules
+ # Omid needs an hbase profile for tagging (doesn't matter which one, the shims need special handling anyway)
+ if [[ "$PROJECT" == "phoenix-omid" ]]; then
+ local variant="${OMID_VARIANTS[1]}"
+ fi
+ echo "${MVN[@]}" ${variant:+"$variant"} versions:set -DnewVersion="$this_version"
+ "${MVN[@]}" ${variant:+"$variant"} versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+ #Hacking around nonstandard maven submodules for phoenix only
for i in phoenix-hbase-compat-*; do
if [ -e "$i" ]; then
- "${MVN[@]}" -pl $i versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+ "${MVN[@]}" ${variant:+"$variant"} -pl $i versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+ fi
+ done
+ #Omid has an even more nonstandard maven structure, and needs more hacks
+ for i in hbase-shims/hbase-*; do
+ if [ -e "$i" ]; then
+ sed -i -e "0,\#<version>.*</version>#{s##<version>${this_version}</version>#}" $i/pom.xml
Review comment:
I tried to find the alternative with options in the version maven plugin to update multi-level parent-child relationship but it seems we have no option other than this hack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #959: PHOENIX-6216 Add Omid and Tephra support to create-release script
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #959:
URL: https://github.com/apache/phoenix/pull/959#issuecomment-726580784
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 3m 12s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | shellcheck | 0m 8s | The patch generated 2 new + 6 unchanged - 1 fixed = 8 total (was 7) |
| +1 :green_heart: | shelldocs | 0m 0s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 10m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-959/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/959 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 8d7c17e1d245 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 6cc9d50 |
| shellcheck | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-959/2/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-959/2/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org