[GitHub] [flink] CrynetLogistics commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

[GitBox <gi...@apache.org>]

CrynetLogistics commented on a change in pull request #17345:
URL: https://github.com/apache/flink/pull/17345#discussion_r739272758



##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java
##########
@@ -49,6 +50,28 @@
 public abstract class AsyncSinkBase<InputT, RequestEntryT extends Serializable>
         implements Sink<InputT, Void, Collection<RequestEntryT>, Void> {
 
+    protected final ElementConverter<InputT, RequestEntryT> elementConverter;
+    protected final Integer maxBatchSize;
+    protected final Integer maxInFlightRequests;
+    protected final Integer maxBufferedRequests;
+    protected final Long flushOnBufferSizeInBytes;
+    protected final Long maxTimeInBufferMS;
+
+    protected AsyncSinkBase(
+            ElementConverter<InputT, RequestEntryT> elementConverter,
+            Integer maxBatchSize,
+            Integer maxInFlightRequests,
+            Integer maxBufferedRequests,
+            Long flushOnBufferSizeInBytes,
+            Long maxTimeInBufferMS) {

Review comment:
       Ah thank you. It's true, by the time the builder had injected the defaults, it's not possible for any of these to be unfilled. So will convert them to primitives!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org