You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Matthijs Kooijman <ma...@stdin.nl> on 2012/02/07 16:31:14 UTC

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Hi folks,

> over a year ago, I submitted a patch to make the
> svn_auth_get_platform_specific_client_providers perl bindings work, to
> allow git-svn to work with gnome_keyring. Since then, I've been working
> on some further improvements, which I've attached as patches.
has anyone got a chance to have a look at these patches? Daniel applied
the first trivial patch, but I'd like to get the others in as wel...

I've refreshed the patches against current trunk and re-attached them.
02-python-platform-providers.patch was changed to resolve a conflict
with r1235264.

Gr.

Matthijs

> For consistency, I've also fixed the
> svn_auth_get_platform_specific_client_providers bindings for python and
> ruby, even though I don't really require them.
> 
> The more fun change is the addition of a new binding that allows you to
> set a gnome_keyring prompt function: Using this, git-svn can ask for a
> keyring unlock password if the keyring is not locked yet (fixing a
> long-standing annoyance where I previously had to open some GUI-thingy
> to unlock the keyring before using git-svn). Again, I've spent some time
> figuring out the python and ruby bindings as well, and made this work
> there too.
> 
> All changes have been tested using two example scripts (needed changes
> included in the patches) for python and ruby and using git-svn for perl
> (for lack of any example scripts). The ruby example script is new, since
> there was no example that accessed a remote url yet. I also fixed the
> python example I used, since it didn't work on trunk.
> 
> I've included testcases for perl and python, but my lacking Ruby skills
> didn't manage to produce testcases for Ruby (there's not much to test,
> anyway...)
> 
> Patches are against svn trunk (r1227522), but also apply with just a
> single trivial conflict to 1.6.17.
> 
> Let me know if there's any further improvments required.

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Daniel Shahaf <da...@elego.de>.
Daniel Shahaf wrote on Wed, Feb 08, 2012 at 02:32:01 +0200:
> r1241713 --- thanks!

And r1241726, since the buildslave runs Python 2.4...

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Daniel Shahaf <da...@elego.de>.
r1241713 --- thanks!

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hi Daniel,

> > Index: subversion-trunk/subversion/bindings/swig/python/tests/client.py
> > ===================================================================
> > --- subversion-trunk.orig/subversion/bindings/swig/python/tests/client.py	2012-02-07 20:13:48.666552472 +0100
> > +++ subversion-trunk/subversion/bindings/swig/python/tests/client.py	2012-02-07 20:35:39.329660618 +0100
> > @@ -378,6 +378,7 @@
> >      providers = core.svn_auth_get_platform_specific_client_providers(None, None)
> >      # Not much more we can test in this minimal environment.
> >      self.assert_(isinstance(providers, list))
> > +    self.assert_(all(map(lambda x: isinstance(x, core.svn_auth_provider_object_t), providers)))
> 
> Tests fail with:
> 
>     core.svn_auth_set_gnome_keyring_unlock_prompt_func(self.client_ctx.auth_baton, prompt_func)
> AttributeError: 'module' object has no attribute 'svn_auth_set_gnome_keyring_unlock_prompt_func'
Note that this is actually the test from the commit Stefan did, that
adds the svn_auth_set_gnome_keyring_unlock_prompt_func function, not the
one from the patch you were testing.

> I think the patch in your mail to Stefan may fix that?
The commit from Stefan to fix the Windows compile actually broke this
testcase. I just sent two more patches to fix this again.

In any case, the patch shown above should work regardless of what Stefan
does, so you should be able to commit that one already.

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Daniel Shahaf <da...@elego.de>.
Matthijs Kooijman wrote on Tue, Feb 07, 2012 at 20:52:08 +0100:
> Hi Daniel,
> 
> > svn_config_get_config() reads from disk.  You'd do that just once (and
> > stash the result in the client context, if svn_cmdline_init() or someone
> > else doesn't do that for you), and then ["config"] it.  (In the C level
> > that's just an apr_hash_get().)
> > 
> > Have a look at what the svn* binaries do.
> Ah, thanks for the pointers, I think I got it now. A closer looks hows
> that ctx.config was even filled already, but a bit further down. I've
> attached a patch to fix this, which now allows me to disable
> gnome-keyring from ~/.subversion/config when running the example.
> 
> > If you don't find a better way (even after asking) I'll also be happy
> > with a test that does a strstr() on the repr() of the objects.
> It turned out that the type is just exported as
> svn.core.svn_auth_provider_object_t, so the change is trivial. See the
> other attached patch.
> 
> Gr.
> 
> Matthijs

> Improve the testcase for the python binding for
> svn_auth_get_platform_specific_client_providers.
> 
> This test was introduced in r1241530, but it only checked if a list was
> returned. Now also the type of the elements of the list is checked.
> 
> * subversion/bindings/swig/python/tests/client.py
>   (test_platform_providers): Improve testcase.
> 
> Patch by: Matthijs Kooijman <ma...@stdin.nl>
> 
> Index: subversion-trunk/subversion/bindings/swig/python/tests/client.py
> ===================================================================
> --- subversion-trunk.orig/subversion/bindings/swig/python/tests/client.py	2012-02-07 20:13:48.666552472 +0100
> +++ subversion-trunk/subversion/bindings/swig/python/tests/client.py	2012-02-07 20:35:39.329660618 +0100
> @@ -378,6 +378,7 @@
>      providers = core.svn_auth_get_platform_specific_client_providers(None, None)
>      # Not much more we can test in this minimal environment.
>      self.assert_(isinstance(providers, list))
> +    self.assert_(all(map(lambda x: isinstance(x, core.svn_auth_provider_object_t), providers)))

Tests fail with:

    core.svn_auth_set_gnome_keyring_unlock_prompt_func(self.client_ctx.auth_baton, prompt_func)
AttributeError: 'module' object has no attribute 'svn_auth_set_gnome_keyring_unlock_prompt_func'

I think the patch in your mail to Stefan may fix that?

>  
>    def testGnomeKeyring(self):
>      # This tests setting the gnome-keyring unlock prompt function as an

> Let the get-location-segments.py example pass a proper config to
> svn_auth_get_platform_specific_client_providers.
> 
> This call was introduced in r1241530, but it did not properly pass a
> configuration option.
> 

Applied unchanged.  Thanks!

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hi Daniel,

> svn_config_get_config() reads from disk.  You'd do that just once (and
> stash the result in the client context, if svn_cmdline_init() or someone
> else doesn't do that for you), and then ["config"] it.  (In the C level
> that's just an apr_hash_get().)
> 
> Have a look at what the svn* binaries do.
Ah, thanks for the pointers, I think I got it now. A closer looks hows
that ctx.config was even filled already, but a bit further down. I've
attached a patch to fix this, which now allows me to disable
gnome-keyring from ~/.subversion/config when running the example.

> If you don't find a better way (even after asking) I'll also be happy
> with a test that does a strstr() on the repr() of the objects.
It turned out that the type is just exported as
svn.core.svn_auth_provider_object_t, so the change is trivial. See the
other attached patch.

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Daniel Shahaf <da...@elego.de>.
Matthijs Kooijman wrote on Tue, Feb 07, 2012 at 19:29:36 +0100:
> Hi Daniel,
> 
> > > +  # ctx.config.config (ctx.config is opaque).
> > 
> > What do you mean by that?
> > 
> > % PYTHONPATH=$prefix/svn-t1/lib/svn-python/ \
> >   python -c 'import svn, svn.core, svn.client; 
> >              print svn.core.svn_config_get_config(None, None)["config"]'
> > <libsvn.core.svn_config_t; proxy of <Swig Object of type 'svn_config_t *' at 0xb734d998> >
> I meant this:
> 
> matthijs@grubby:~/docs/src/upstream/subversion-trunk$  python -c 'import svn, svn.core, svn.client;print svn.core.svn_config_get_config(None, None)["config"]'
> Traceback (most recent call last):
>   File "<string>", line 1, in <module>
>   File "/usr/lib/pymodules/python2.7/libsvn/core.py", line 5494, in __getattr__
>     value = _swig_getattr(self, self.__class__, name)
>   File "/usr/lib/pymodules/python2.7/libsvn/core.py", line 51, in _swig_getattr
>     raise AttributeError(name)
> AttributeError: __getitem__
> 
> On trunk, your code seems to work (but there, ctx.config still seems to be None, though).
> 
> Would using svn.core.svn_config_get_config(None, None)["config"] here be the
> recommended practice?
> 

svn_config_get_config() reads from disk.  You'd do that just once (and
stash the result in the client context, if svn_cmdline_init() or someone
else doesn't do that for you), and then ["config"] it.  (In the C level
that's just an apr_hash_get().)

Have a look at what the svn* binaries do.

> > > +++ subversion-trunk/subversion/bindings/swig/python/tests/client.py	2012-02-07 16:20:36.914353499 +0100
> > > @@ -374,6 +374,11 @@
> > >  
> > >      self.assertEqual(readme_text, 'This is a test.\n')
> > >  
> > > +  def test_platform_providers(self):
> > > +    providers = core.svn_auth_get_platform_specific_client_providers(None, None)
> > > +    # Not much more we can test in this minimal environment.
> > > +    self.assert_(isinstance(providers, list))
> > > +
> > 
> > You could assert
> > 
> >     all(map(lambda x: isinstance(x, 'svn_auth_provider_object_t *'),
> >             list))
> > 
> > like the Perl revision you refer to does. 
> I couldn't figure out how to do that in the face of swig types. Your suggestion
> doesn't work either:
> 
> TypeError: isinstance() arg 2 must be a class, type, or tuple of classes and types
> 

It was pseudocode :-)

If you don't find a better way (even after asking) I'll also be happy
with a test that does a strstr() on the repr() of the objects.

> > I've committed this patch.  (I had to rewrite the log message to conform
> > to our style of mentioning every symbol[1].)  Please send followups as
> > patches against the new HEAD.
> Thanks! I thought I had a policy-compliant log message already, but it seems
> you've been even more thorough. I'll keep that in mind for further patches.
> 

You did mention most/all of the changed symbols, but you didn't do so in
the

  * path/to/file
    (symbol_name): %s

format.

> Gr.
> 
> Matthijs



Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hi Daniel,

> > +  # ctx.config.config (ctx.config is opaque).
> 
> What do you mean by that?
> 
> % PYTHONPATH=$prefix/svn-t1/lib/svn-python/ \
>   python -c 'import svn, svn.core, svn.client; 
>              print svn.core.svn_config_get_config(None, None)["config"]'
> <libsvn.core.svn_config_t; proxy of <Swig Object of type 'svn_config_t *' at 0xb734d998> >
I meant this:

matthijs@grubby:~/docs/src/upstream/subversion-trunk$  python -c 'import svn, svn.core, svn.client;print svn.core.svn_config_get_config(None, None)["config"]'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/pymodules/python2.7/libsvn/core.py", line 5494, in __getattr__
    value = _swig_getattr(self, self.__class__, name)
  File "/usr/lib/pymodules/python2.7/libsvn/core.py", line 51, in _swig_getattr
    raise AttributeError(name)
AttributeError: __getitem__

On trunk, your code seems to work (but there, ctx.config still seems to be None, though).

Would using svn.core.svn_config_get_config(None, None)["config"] here be the
recommended practice?

> > +++ subversion-trunk/subversion/bindings/swig/python/tests/client.py	2012-02-07 16:20:36.914353499 +0100
> > @@ -374,6 +374,11 @@
> >  
> >      self.assertEqual(readme_text, 'This is a test.\n')
> >  
> > +  def test_platform_providers(self):
> > +    providers = core.svn_auth_get_platform_specific_client_providers(None, None)
> > +    # Not much more we can test in this minimal environment.
> > +    self.assert_(isinstance(providers, list))
> > +
> 
> You could assert
> 
>     all(map(lambda x: isinstance(x, 'svn_auth_provider_object_t *'),
>             list))
> 
> like the Perl revision you refer to does. 
I couldn't figure out how to do that in the face of swig types. Your suggestion
doesn't work either:

TypeError: isinstance() arg 2 must be a class, type, or tuple of classes and types

> I've committed this patch.  (I had to rewrite the log message to conform
> to our style of mentioning every symbol[1].)  Please send followups as
> patches against the new HEAD.
Thanks! I thought I had a policy-compliant log message already, but it seems
you've been even more thorough. I'll keep that in mind for further patches.

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Daniel Shahaf <da...@elego.de>.
Matthijs Kooijman wrote on Tue, Feb 07, 2012 at 17:14:32 +0100:
> Hi Stefan,
> 
> > It appears the attachment is missing.
> Yeah, motoric memory took over and I sent the mail, while I intended to
> actually test the patches again before resending.
> 
> So, here's the updated _and_ tested patches, attached this time.
> 
> Gr.
> 
> Matthijs

> Index: subversion-trunk/tools/examples/get-location-segments.py
> ===================================================================
> --- subversion-trunk.orig/tools/examples/get-location-segments.py	2012-02-07 16:19:07.413853775 +0100
> +++ subversion-trunk/tools/examples/get-location-segments.py	2012-02-07 16:20:36.914353499 +0100
> @@ -125,7 +125,13 @@
>  
>    core.svn_config_ensure(None)
>    ctx = client.svn_client_create_context()
> -  providers = [
> +
> +  # Make sure that these are at the start of the list, so passwords from
> +  # gnome-keyring / kwallet are checked before asking for new passwords.
> +  # Note that we don't pass our config here, since we can't seem to access
> +  # ctx.config.config (ctx.config is opaque).

What do you mean by that?

% PYTHONPATH=$prefix/svn-t1/lib/svn-python/ \
  python -c 'import svn, svn.core, svn.client; 
             print svn.core.svn_config_get_config(None, None)["config"]'
<libsvn.core.svn_config_t; proxy of <Swig Object of type 'svn_config_t *' at 0xb734d998> >

> +++ subversion-trunk/subversion/bindings/swig/python/tests/client.py	2012-02-07 16:20:36.914353499 +0100
> @@ -374,6 +374,11 @@
>  
>      self.assertEqual(readme_text, 'This is a test.\n')
>  
> +  def test_platform_providers(self):
> +    providers = core.svn_auth_get_platform_specific_client_providers(None, None)
> +    # Not much more we can test in this minimal environment.
> +    self.assert_(isinstance(providers, list))
> +

You could assert

    all(map(lambda x: isinstance(x, 'svn_auth_provider_object_t *'),
            list))

like the Perl revision you refer to does. 

> 

I've committed this patch.  (I had to rewrite the log message to conform
to our style of mentioning every symbol[1].)  Please send followups as
patches against the new HEAD.

Thanks!

Daniel

[1] http://subversion.apache.org/docs/community-guide/conventions#log-messages

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Feb 07, 2012 at 11:12:22PM +0100, Matthijs Kooijman wrote:
> I've attached a patch which should make the unlock prompt function agian
> on Linux, while not breaking on Windows. I also found a keyword in swig
> that removes the need for a separate declaration and implementation of
> the function, which I also used in this patch.
> 
> I've also attached a patch to prevent the testcase from running when
> gnome-keyring is not available, to prevent the test suite from failing
> on e.g. Windows.

Nice. Committed both of them. Cheers!

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hey Stefan,

> Hold on there, it seems that doesn't work either. Perhaps the
> SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC constant isn't defined
> when swig runs or something, I'll have a closer look now.
I've attached a patch which should make the unlock prompt function agian
on Linux, while not breaking on Windows. I also found a keyword in swig
that removes the need for a separate declaration and implementation of
the function, which I also used in this patch.

I've also attached a patch to prevent the testcase from running when
gnome-keyring is not available, to prevent the test suite from failing
on e.g. Windows.

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hey Stefan,

> So, you'll have to drop the {% %} (which is effectively my patch again)
> ;-p
Hold on there, it seems that doesn't work either. Perhaps the
SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC constant isn't defined
when swig runs or something, I'll have a closer look now.

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hey Stefan,

> Thanks. I've already committed a similar fix in r1241585.
> I wasn't quite sure if it was gonna work but glad you had the same idea :)

Actually, I just tried your fix and it doesn't work. It'll fix the build
error on win32, but it also breaks the binding on systems that do have
gnome-keyring (since the {% %} causes the declaration to be included in
the generated core.c, but it is skipped for determining what bindings to
generate (so no binding is generated in core.c).

So, you'll have to drop the {% %} (which is effectively my patch again)
;-p

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Feb 07, 2012 at 09:06:03PM +0100, Matthijs Kooijman wrote:
> Hey Stefan,
> 
> > FYI, the latter patch fails to compile on Windows.
> > See http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/6580/steps/Build%20Bindings/logs/stdio
> Woops, i forgot to #ifdef the declaration like I did with the
> implmentation. I reproduced the error here by disabling gnome-keyring
> and attached a patch to fix it.

Thanks. I've already committed a similar fix in r1241585.
I wasn't quite sure if it was gonna work but glad you had the same idea :)

> Add missing ifdefs around declaration of
> svn_auth_set_gnome_keyring_unlock_prompt_func (introduced in r1241554).
> 
> There were ifdefs around the implementation already, but not around the
> declaration. This caused a compilation failure in the swig bindings on
> platforms that did not have gnome-keyring, since a wrapper for a
> non-existent function would be generated.
> 
> * core.i
>   (svn_auth_set_gnome_keyring_unlock_prompt_func): Don not generate
>     wrapper when gnome-keyring is not available.
> 
> Index: subversion-trunk/subversion/bindings/swig/core.i
> ===================================================================
> --- subversion-trunk.orig/subversion/bindings/swig/core.i	2012-02-07 21:01:37.386228892 +0100
> +++ subversion-trunk/subversion/bindings/swig/core.i	2012-02-07 21:01:46.162276754 +0100
> @@ -792,11 +792,12 @@
>  %include svn_pools_h.swg
>  %include svn_version_h.swg
>  
> +#ifdef SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC
>  /* This is the function defined above */
>  void svn_auth_set_gnome_keyring_unlock_prompt_func(svn_auth_baton_t *ab,
>                                                     svn_auth_gnome_keyring_unlock_prompt_func_t prompt_func,
>                                                     void *prompt_baton);
> -
> +#endif
>  
>  /* The constant SVN_PROP_REVISION_ALL_PROPS is a C fragment, not a single
>     data value, so the SWIG parser will raise a 305 warning if we don't




Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hey Stefan,

> FYI, the latter patch fails to compile on Windows.
> See http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/6580/steps/Build%20Bindings/logs/stdio
Woops, i forgot to #ifdef the declaration like I did with the
implmentation. I reproduced the error here by disabling gnome-keyring
and attached a patch to fix it.

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Feb 07, 2012 at 08:12:55PM +0100, Stefan Sperling wrote:
> Thanks. I've committed this, and your other patch (r1241553 and r1241554).

FYI, the latter patch fails to compile on Windows.
See http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/6580/steps/Build%20Bindings/logs/stdio

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Stefan Sperling <st...@selego.de>.
On Tue, Feb 07, 2012 at 07:42:15PM +0100, Matthijs Kooijman wrote:
> Hi Stefan,
> 
> > Can you please add a copyright and licence header to the new file
> > subversion-trunk/tools/examples/info.rb? Thanks!
> I've attached an updated version of the patch, including the same
> license header as the other examples.
> 

Thanks. I've committed this, and your other patch (r1241553 and r1241554).
If you want to make any further tweaks based on feedback you've received
so far please send new patches against latest HEAD.

Thanks a lot for taking care of this!

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hi Stefan,

> Can you please add a copyright and licence header to the new file
> subversion-trunk/tools/examples/info.rb? Thanks!
I've attached an updated version of the patch, including the same
license header as the other examples.

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Feb 07, 2012 at 05:14:32PM +0100, Matthijs Kooijman wrote:
> Hi Stefan,
> 
> > It appears the attachment is missing.
> Yeah, motoric memory took over and I sent the mail, while I intended to
> actually test the patches again before resending.
> 
> So, here's the updated _and_ tested patches, attached this time.
> 
> Gr.
> 
> Matthijs

Looks great.

Can you please add a copyright and licence header to the new file
subversion-trunk/tools/examples/info.rb? Thanks!

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Matthijs Kooijman <ma...@stdin.nl>.
Hi Stefan,

> It appears the attachment is missing.
Yeah, motoric memory took over and I sent the mail, while I intended to
actually test the patches again before resending.

So, here's the updated _and_ tested patches, attached this time.

Gr.

Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Stefan Sperling wrote on Tue, Feb 07, 2012 at 16:37:54 +0100:
> On Tue, Feb 07, 2012 at 04:31:14PM +0100, Matthijs Kooijman wrote:
> > Hi folks,
> > 
> > > over a year ago, I submitted a patch to make the
> > > svn_auth_get_platform_specific_client_providers perl bindings work, to
> > > allow git-svn to work with gnome_keyring. Since then, I've been working
> > > on some further improvements, which I've attached as patches.
> > has anyone got a chance to have a look at these patches? Daniel applied
> > the first trivial patch, but I'd like to get the others in as wel...
> > 
> > I've refreshed the patches against current trunk and re-attached them.
> > 02-python-platform-providers.patch was changed to resolve a conflict
> > with r1235264.
> 
> It appears the attachment is missing.
> 
> Sometimes the apache.org lists discard attachments silently.
> I am not sure if got this fixed yet.

It's fixed, our dev@ list should allow attachments.

> 
> Or maybe you simply forgot to attach the files?
> You can also send patches inline instead of as an attachment.

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Feb 07, 2012 at 04:31:14PM +0100, Matthijs Kooijman wrote:
> Hi folks,
> 
> > over a year ago, I submitted a patch to make the
> > svn_auth_get_platform_specific_client_providers perl bindings work, to
> > allow git-svn to work with gnome_keyring. Since then, I've been working
> > on some further improvements, which I've attached as patches.
> has anyone got a chance to have a look at these patches? Daniel applied
> the first trivial patch, but I'd like to get the others in as wel...
> 
> I've refreshed the patches against current trunk and re-attached them.
> 02-python-platform-providers.patch was changed to resolve a conflict
> with r1235264.

It appears the attachment is missing.

Sometimes the apache.org lists discard attachments silently.
I am not sure if got this fixed yet.

Or maybe you simply forgot to attach the files?
You can also send patches inline instead of as an attachment.