[GitHub] [apisix] spacewander commented on a change in pull request #2815: fix: check decrypt key to prevent lua thread aborted

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #2815:
URL: https://github.com/apache/apisix/pull/2815#discussion_r528491016



##########
File path: apisix/ssl/router/radixtree_sni.lua
##########
@@ -67,12 +67,18 @@ local function decrypt_priv_pkey(iv, key)
         return key
     end
 
-    local decrypted = iv:decrypt(ngx_decode_base64(key))
-    if decrypted then
-        return decrypted
+    local decoded_key = ngx_decode_base64(key)
+    if not decoded_key then
+        core.log.error("base64 decode ssl key failed. key[", key, "] ")

Review comment:
       Better to mention that we will skip the bad key in the error message.

##########
File path: apisix/ssl/router/radixtree_sni.lua
##########
@@ -67,12 +67,18 @@ local function decrypt_priv_pkey(iv, key)
         return key
     end
 
-    local decrypted = iv:decrypt(ngx_decode_base64(key))
-    if decrypted then
-        return decrypted
+    local decoded_key = ngx_decode_base64(key)
+    if not decoded_key then
+        core.log.error("base64 decode ssl key failed. key[", key, "] ")
+        return
     end
 
-    core.log.error("decrypt ssl key failed. key[", key, "] ")
+    local decrypted = iv:decrypt(decoded_key)
+    if not decrypted then
+        core.log.error("decrypt ssl key failed. key[", key, "] ")

Review comment:
       ditto




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org