You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nlivens <gi...@git.apache.org> on 2016/06/02 10:19:44 UTC
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1580
CLOUDSTACK-9402 : Support for underlay features (PAT & FIP2UL) in Nuage VSP plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1580.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1580
----
commit c86ab936f03b9815debaa535065df10dc724149f
Author: Eric Waegeman <er...@nuagenetworks.net>
Date: 2016-05-26T09:37:52Z
CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin
commit 064646de7604ffb58a4ae7ecc3db103e4e067fbf
Author: rahul singal <ra...@alcatel-lucent.com>
Date: 2016-06-02T09:30:25Z
CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp
commit 60a3b4e27bc6384697025f7263428804c43f9b64
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-04-28T13:52:17Z
CLOUDSTACK-9402 : Support for underlay features (PAT & FIP2UL) in Nuage VSP plugin
commit ef522a07ecd2f0c98d90ba054d4e7d69e95c1f67
Author: Prashanth Manthena <pr...@alcatel-lucent.com>
Date: 2016-05-26T10:48:02Z
CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including PAT/FIP2UL features with NuageVsp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89472040
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -0,0 +1,804 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
FYI, this deleted file is still being referenced in one of the Marvin smoke tests test/integration/smoke/test_staticroles.py (refer its setUp class).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@jburwell a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$
@remibergsma Our Marvin test code is now truly PEP8 & PyFlakes compliant. Moreover, we have extended our custom base class "test/integration/plugins/nuagevsp/nuageTestCase.py" support for optimal creation of cloudstack objects at setUpClass level in order to re-use/test them across different testcases. Thus, conserving test resources (i.e. reduced test created objects and time).
Note: We have updated with these changes our other outstanding PRs as well.
Let me know, if you have any other questions for me.
Thank you for your valuable review and suggestions !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Thanks @prashanthvarma I'll rekick some tests and awaiting for your test results.
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd I have resolved and responded to your comments, and updated the PR accordingly. Moreover, I have just kicked on our internal regression tests (including the added Marvin tests in this PR that test the code changes in this PR).
Regarding the above failures, all of them are either test environment (intermittent errors) and are not related to the code changes in this PR.
1) TestRVPCSite2SiteVpn - Failing to download the template in the setupClass.
Exception("Template download failed exception")
2) test_02_vpc_privategw_static_routes - Failing to create privategateway in the VPC as the specified vlan is already in use.
errorText:Network with vlan vlan://926 already exists in zone 1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89471555
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs):
cmd.listall = True
return(apiclient.listPortableIpRanges(cmd))
+
+class NuageUnderlayPublicIpRange:
--- End diff --
Agree, but this is a key infrastructure query API for Nuage VSP SDN platform (overlay vs underlay networking). Moreover, our custom base/utility class "nuageTestCase.py" also imports and uses this class. Thus, we have added it to the Marvin base class "base.py" for cleaner abstraction and code usage.
For other Nuage VSP supported feature specific/custom APIs, we tend to include them in our custom base/utility class "nuageTestCase.py" at test/integration/plugins/nuagevsp/.
Let me know, if you still think otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by nlivens <gi...@git.apache.org>.
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1580
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin
Support for underlay features (Source & Static NAT to underlay) with Nuage VSP SDN Plugin including Marvin test coverage for corresponding Source & Static NAT features on master. Moreover, our Marvin tests are written in such a way that they can validate our supported feature set with both Nuage VSP SDN platform's overlay and underlay infra.
PR contents:
1) Support for Source NAT to underlay feature on master with Nuage VSP SDN Plugin.
2) Support for Static NAT to underlay feature on master with Nuage VSP SDN Plugin.
3) Marvin test coverage for Source & Static NAT to underlay on master with Nuage VSP SDN Plugin.
4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
5) PEP8 & PyFlakes compliance with our Marvin test code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1580.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1580
----
commit e5fd206e7e090121798c80745df4629f890e3234
Author: Eric Waegeman <er...@nuagenetworks.net>
Date: 2016-05-26T09:37:52Z
CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin
commit ec7b6a5f887555e513b1d1d9c5e469eb079d721a
Author: Prashanth Manthena <pr...@alcatel-lucent.com>
Date: 2016-05-26T10:48:02Z
CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including PAT/FIP2UL features with NuageVsp
commit be8ae9376664925255595a50f5c4574c4abb7179
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-06-15T09:04:21Z
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin
commit a2e1999bbacf3e00570bd51492b05cda8ca81c7d
Author: Rahul Singal <ra...@nuagenetworks.net>
Date: 2016-07-01T13:22:50Z
CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
PEP8 recommends max line length of 79, why bump it to 150? That doesn't help in readability IMO. And yes, I know many other tests are crappy formatted too. But since you state it's PEP8 complaint I suggest to do it fully :-)
Does that test take >7 hours? Wow. Do you have any metrics on why that takes so long?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89277160
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -0,0 +1,804 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
Remove this file, we don't need it now that we've dynamic roles feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89540443
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs):
cmd.listall = True
return(apiclient.listPortableIpRanges(cmd))
+
+class NuageUnderlayPublicIpRange:
--- End diff --
@rhtyd I am convinced with your reasoning, I will move the module to our directory plugins/nuagevsp, and will update you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@jburwell a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89277386
--- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/EnableNuageUnderlayVlanIpRangeCmd.java ---
@@ -0,0 +1,110 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import javax.inject.Inject;
+
+@APICommand(name = EnableNuageUnderlayVlanIpRangeCmd.APINAME, description = "enable Nuage underlay on vlan ip range", responseObject = SuccessResponse.class,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ since = "4.9",
--- End diff --
Fix this to 4.10.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd I have resolved all your comments and updated the PR. Moreover, all the tests that are run on this PR are now fully successful (blueorangutan tests + added Marvin tests in this PR).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1580
### ACS CI BVT Run
**Sumarry:**
Build Number 208
Hypervisor xenserver
NetworkType Advanced
Passed=72
Failed=1
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_vm_life_cycle.py
* test_10_attachAndDetach_iso Failing since 2 runs
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@prashanthvarma I still see 4 different commits, can you squash them? At least squash the similar ones together, so we can effectively get two commits one around the feature and one around the marvin test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
<b>Trillian test result (tid-346)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25383 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1580-t346-kvm-centos7.zip
Test completed. 47 look ok, 1 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 854.81 | test_vpc_redundant.py
test_01_vpc_site2site_vpn | Success | 145.38 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.12 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 250.93 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 269.98 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 560.06 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 529.09 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1326.70 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 553.12 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1275.78 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.67 | test_volumes.py
test_08_resize_volume | Success | 15.52 | test_volumes.py
test_07_resize_fail | Success | 20.45 | test_volumes.py
test_06_download_detached_volume | Success | 15.32 | test_volumes.py
test_05_detach_volume | Success | 100.29 | test_volumes.py
test_04_delete_attached_volume | Success | 10.21 | test_volumes.py
test_03_download_attached_volume | Success | 15.28 | test_volumes.py
test_02_attach_volume | Success | 43.59 | test_volumes.py
test_01_create_volume | Success | 716.01 | test_volumes.py
test_deploy_vm_multiple | Success | 273.57 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.73 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.24 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 35.91 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 126.04 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.82 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.16 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 65.59 | test_templates.py
test_08_list_system_templates | Success | 0.06 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.12 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 70.56 | test_templates.py
test_10_destroy_cpvm | Success | 161.63 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.14 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.25 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.11 | test_ssvm.py
test_06_stop_cpvm | Success | 131.42 | test_ssvm.py
test_05_stop_ssvm | Success | 133.22 | test_ssvm.py
test_04_cpvm_internals | Success | 0.93 | test_ssvm.py
test_03_ssvm_internals | Success | 2.85 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.22 | test_snapshots.py
test_04_change_offering_small | Success | 239.59 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
test_09_reboot_router | Success | 35.29 | test_routers.py
test_08_start_router | Success | 25.24 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py
test_06_router_advanced | Success | 0.05 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.59 | test_routers.py
test_03_restart_network_cleanup | Success | 55.48 | test_routers.py
test_02_router_internal_adv | Success | 0.84 | test_routers.py
test_01_router_internal_basic | Success | 0.46 | test_routers.py
test_router_dns_guestipquery | Success | 76.77 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.07 | test_router_dns.py
test_router_dhcphosts | Success | 241.62 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.07 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 130.99 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.21 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.47 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 507.21 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 495.85 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 376.33 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 83.15 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.81 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.18 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.46 | test_portable_publicip.py
test_isolate_network_password_server | Success | 89.53 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.12 | test_over_provisioning.py
test_oobm_zchange_password | Success | 20.52 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.52 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.51 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.51 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.52 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 62.71 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.16 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.10 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.20 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.13 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.10 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.10 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 29.56 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.29 | test_non_contigiousvlan.py
test_01_nic | Success | 606.50 | test_nic.py
test_releaseIP | Success | 188.32 | test_network.py
test_reboot_router | Success | 399.47 | test_network.py
test_public_ip_user_account | Success | 10.23 | test_network.py
test_public_ip_admin_account | Success | 40.29 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.84 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.66 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 122.43 | test_network.py
test_delete_account | Success | 324.07 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.65 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.71 | test_network.py
test_nic_secondaryip_add_remove | Success | 208.61 | test_multipleips_per_nic.py
login_test_saml_user | Success | 25.01 | test_login.py
test_assign_and_removal_lb | Success | 133.23 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.08 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 197.69 | test_loadbalance.py
test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.15 | test_iso.py
test_03_delete_iso | Success | 95.19 | test_iso.py
test_02_edit_iso | Success | 0.06 | test_iso.py
test_01_create_iso | Success | 21.99 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 234.21 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 198.02 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 519.80 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 444.81 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.27 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.06 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 65.89 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 20.57 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 65.92 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.51 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 60.77 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.86 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 7.03 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 233.36 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 213.39 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 106.33 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.31 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_rolepermission_lifecycle_update | Skipped | 0.02 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Skipped | 0.02 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Skipped | 0.02 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Skipped | 0.02 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_update | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_list | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_delete | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_create | Skipped | 0.02 | test_dynamicroles.py
test_role_inuse_deletion | Skipped | 0.02 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Skipped | 0.02 | test_dynamicroles.py
test_role_account_acls | Skipped | 0.02 | test_dynamicroles.py
test_default_role_deletion | Skipped | 0.03 | test_dynamicroles.py
test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89534499
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs):
cmd.listall = True
return(apiclient.listPortableIpRanges(cmd))
+
+class NuageUnderlayPublicIpRange:
--- End diff --
I understand it's easier that way and that's what others have been doing, but I disagree here and this pattern need to stop.
If you put the utility in the plugins/nuagevsp your nuage specific integration tests in that directory can still import from the utility just as you import from marvin.base, this I think will be much clearer implementation than keep adding resource/utility classes to the base marvin utility. In fact, I think this module should not be part of Marvin at all. I've similar thoughts about the test_data, a single source of test data consumed by all tests and that too within Marvin.
Adding more test-specific dependencies in Marvin will make it harder to split Marvin as a standalone library. The library should be made independent of tests, and allow tests to have their own test data and utilities. That said, I understand the accumulated technical debt is nobody's fault, it just happened and we had no guideline or enforcement at the time.
I still want to encourage best practices, and if there is lack of bandwidth I could still help with the merge with hope to address this technical debt in a future refactoring round.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@jburwell @rhtyd I have rebased this PR with latest master, and squashed commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@jburwell I have squashed all the commits in this PR into one logical commit as suggested by you.
Moreover, I have briefly investigated the above failed test "test_02_redundant_VPC_default_routes" and here are my findings:
1) The above test case fails during establishment of SSH connection to the VM via its public IP (SSH connection failed to setup, timeout error)
2) It looks like a test code (and/or) test environment issue as similar SSH tests in other test cases in the same test script "test_vpc_redundant.py" pass.
3) The only difference between this failing test case and other test cases being the number of retries while establishing SSH connection to the VM via its public IP (0 and 5 retries respectively). Thus, most likely, increasing the number of retries in the failing test case will fix this issue on your test environment.
4) This test case fails at the same point across different PRs (e.g. PR #1577 and PR #1579 )
Conclusion: The above test "test_02_redundant_VPC_default_routes" is failing due to test code (and/or) test environment issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
LGTM - based on our Internal regression testing and code review on the latest code in this PR.
@rhtyd @jburwell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89447356
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs):
cmd.listall = True
return(apiclient.listPortableIpRanges(cmd))
+
+class NuageUnderlayPublicIpRange:
--- End diff --
I would avoid having non-core components/base resource classes in base.py/marvin. Instead such a class can be moved into a utility module at test/integration/plugins/nuagevsp/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
<b>Trillian test result (tid-395)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27905 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1580-t395-kvm-centos7.zip
Test completed. 45 look ok, 3 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 184.14 | test_privategw_acl.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 520.17 | test_vpc_redundant.py
test_01_vpc_site2site_vpn | Success | 155.01 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 71.31 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 259.79 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 551.66 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 515.06 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1446.78 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 558.87 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 749.94 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1366.96 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.56 | test_volumes.py
test_08_resize_volume | Success | 15.40 | test_volumes.py
test_07_resize_fail | Success | 20.47 | test_volumes.py
test_06_download_detached_volume | Success | 15.30 | test_volumes.py
test_05_detach_volume | Success | 100.25 | test_volumes.py
test_04_delete_attached_volume | Success | 10.20 | test_volumes.py
test_03_download_attached_volume | Success | 15.34 | test_volumes.py
test_02_attach_volume | Success | 74.55 | test_volumes.py
test_01_create_volume | Success | 721.57 | test_volumes.py
test_deploy_vm_multiple | Success | 309.12 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.74 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 41.06 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.84 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 126.11 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.33 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 85.76 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.10 | test_templates.py
test_04_extract_template | Success | 5.18 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.36 | test_templates.py
test_01_create_template | Success | 80.69 | test_templates.py
test_10_destroy_cpvm | Success | 161.74 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.79 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.50 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.28 | test_ssvm.py
test_06_stop_cpvm | Success | 131.75 | test_ssvm.py
test_05_stop_ssvm | Success | 133.77 | test_ssvm.py
test_04_cpvm_internals | Success | 0.99 | test_ssvm.py
test_03_ssvm_internals | Success | 2.96 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.35 | test_snapshots.py
test_04_change_offering_small | Success | 234.54 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
test_09_reboot_router | Success | 40.35 | test_routers.py
test_08_start_router | Success | 30.32 | test_routers.py
test_07_stop_router | Success | 10.17 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.70 | test_routers.py
test_03_restart_network_cleanup | Success | 60.53 | test_routers.py
test_02_router_internal_adv | Success | 1.11 | test_routers.py
test_01_router_internal_basic | Success | 0.58 | test_routers.py
test_router_dns_guestipquery | Success | 107.08 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.06 | test_router_dns.py
test_router_dhcphosts | Success | 317.22 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.08 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 166.16 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.21 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.42 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 517.43 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 556.83 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 113.28 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 36.08 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.18 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.45 | test_portable_publicip.py
test_isolate_network_password_server | Success | 60.12 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.17 | test_over_provisioning.py
test_oobm_zchange_password | Success | 20.58 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.52 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.52 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.50 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.53 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.51 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.52 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 62.62 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.23 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.21 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.10 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.10 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 29.84 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.34 | test_non_contigiousvlan.py
test_01_nic | Success | 636.34 | test_nic.py
test_releaseIP | Success | 248.77 | test_network.py
test_reboot_router | Success | 394.56 | test_network.py
test_public_ip_user_account | Success | 10.26 | test_network.py
test_public_ip_admin_account | Success | 40.29 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.64 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.52 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 123.90 | test_network.py
test_delete_account | Success | 303.86 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.66 | test_network.py
test_01_port_fwd_on_src_nat | Success | 113.42 | test_network.py
test_nic_secondaryip_add_remove | Success | 218.52 | test_multipleips_per_nic.py
login_test_saml_user | Success | 24.63 | test_login.py
test_assign_and_removal_lb | Success | 133.53 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.42 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 207.70 | test_loadbalance.py
test_03_list_snapshots | Success | 0.09 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.07 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.33 | test_iso.py
test_03_delete_iso | Success | 95.21 | test_iso.py
test_02_edit_iso | Success | 0.06 | test_iso.py
test_01_create_iso | Success | 22.11 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 233.59 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 177.83 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 491.22 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 419.17 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.30 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.10 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.07 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.06 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.09 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.11 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.60 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 20.61 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 115.98 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 40.69 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 60.78 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.91 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.84 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 253.88 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 248.94 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 96.17 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.33 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.03 | test_ssvm.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_rolepermission_lifecycle_update | Skipped | 0.02 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Skipped | 0.02 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Skipped | 0.02 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Skipped | 0.02 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_update | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_list | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_delete | Skipped | 0.02 | test_dynamicroles.py
test_role_lifecycle_create | Skipped | 0.02 | test_dynamicroles.py
test_role_inuse_deletion | Skipped | 0.02 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Skipped | 0.02 | test_dynamicroles.py
test_role_account_acls | Skipped | 0.02 | test_dynamicroles.py
test_default_role_deletion | Skipped | 0.03 | test_dynamicroles.py
test_deploy_vgpu_enabled_vm | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@prashanthvarma please squash all commits down into one logical commit for the enhancement. Multiple commits for the same feature muddy the long term history.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here. Moreover, we can re-run the added Marvin tests and share the results after the re-base.
This PR has dependency from our other open PR #1578 . Thus, we included that PR commits in this PR.
Generally, we have two commits in a PR, one for dev and one for test (Marvin).
Let me know, if you want us to do this in a different way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@nlivens I would like to get this PR merged for 4.10.0.0. I will code review in the next few days. In the meantime, please rebase this PR to pick up the latest Marvin enhancements/fixes, as well as, resolve conflicts, and squash the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89277419
--- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageUnderlayVlanIpRangesCmd.java ---
@@ -0,0 +1,80 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.api.response.NuageVlanIpRangeResponse;
+import com.cloud.dc.Vlan;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.Pair;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.command.admin.vlan.ListVlanIpRangesCmd;
+import org.apache.cloudstack.api.response.ListResponse;
+
+import javax.inject.Inject;
+import java.util.List;
+
+@APICommand(name = "listNuageUnderlayVlanIpRanges", description = "enable Nuage underlay on vlan ip range", responseObject = NuageVlanIpRangeResponse.class,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ since = "4.9",
--- End diff --
Fix this to 4.10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@prashanthvarma #1578 has been merged. Can you rebase this PR and squash the commits? Once that is done and Jenkins and Travis are green, I will kick regression tests via blueorganutan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89277328
--- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/DisableNuageUnderlayVlanIpRangeCmd.java ---
@@ -0,0 +1,110 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import javax.inject.Inject;
+
+@APICommand(name = DisableNuageUnderlayVlanIpRangeCmd.APINAME, description = "disable Nuage underlay on vlan ip range", responseObject = SuccessResponse.class,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ since = "4.9",
--- End diff --
Fix this to 4.10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Our Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$
Validations:
1) Underlay infra (PAT & FIP2UL)
Marvin test run:
nosetests --with-marvin --marvin-config=nuage.cfg plugins/nuagevsp/test_nuage_source_nat.py
Test results:
Test Nuage VSP Isolated networks with different combinations of Source NAT service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Source NAT service providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 8 tests in 13360.858s
OK
Marvin test run:
nosetests --with-marvin --marvin-config=nuage.cfg plugins/nuagevsp/test_nuage_static_nat.py
Test results:
Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range creation and deletion ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Isolated networks with different combinations of Static NAT service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Static NAT service providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 10 tests in 9472.468s
OK
2) Overlay Infra (Source & Static NAT)
Marvin test run:
nosetests --with-marvin --marvin-config=nuage.cfg plugins/nuagevsp/test_nuage_source_nat.py
Test results:
Test Nuage VSP Isolated networks with different combinations of Source NAT service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Source NAT service providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for Isolated network by performing (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with network restarts by performing (wget) traffic tests to the ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
----------------------------------------------------------------------
Ran 8 tests in 1213.858s
OK (SKIP=6)
Marvin test run:
nosetests --with-marvin --marvin-config=nuage.cfg plugins/nuagevsp/test_nuage_static_nat.py
Test results:
Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range creation and deletion ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Isolated networks with different combinations of Static NAT service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Static NAT service providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 10 tests in 8972.563s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by nlivens <gi...@git.apache.org>.
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1580
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin
Support for underlay features (Source & Static NAT to underlay) with Nuage VSP SDN Plugin including Marvin test coverage for corresponding Source & Static NAT features on master. Moreover, our Marvin tests are written in such a way that they can validate our supported feature set with both Nuage VSP SDN platform's overlay and underlay infra.
PR contents:
1) Support for Source NAT to underlay feature on master with Nuage VSP SDN Plugin.
2) Support for Static NAT to underlay feature on master with Nuage VSP SDN Plugin.
3) Marvin test coverage for Source & Static NAT to underlay on master with Nuage VSP SDN Plugin.
4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
5) PEP8 & PyFlakes compliance with our Marvin test code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1580.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1580
----
commit 22fb8acf90d12925790375738f74c7c1ec4f6e63
Author: Eric Waegeman <er...@nuagenetworks.net>
Date: 2016-05-26T09:37:52Z
CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin
commit 57117e05a0e46a9f49b8065f9a7704a2eaeb86d3
Author: Rahul Singal <ra...@nuagenetworks.net>
Date: 2016-07-01T13:22:50Z
CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp
commit fd5f61c4776fb2404177df1108445a4e8809daae
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-06-15T09:04:21Z
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin
commit 315e341a893872b0eecfb737cc659e699dde1eae
Author: Prashanth Manthena <pr...@alcatel-lucent.com>
Date: 2016-05-26T10:48:02Z
CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including PAT/FIP2UL features with NuageVsp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd @jburwell As I mentioned in the earlier comments, this feature PR has dependency with our other open feature PR #1578. Thus, we re-based this PR (2 commits) on top of that PR (2 commits) as we don't know which PR will go in first.
One option:
Once PR #1578 has been merged into master, we will re-base this PR with latest master. Thus, we will have only two commits in this PR.
Let me know, if you want us to do this in a different way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89308445
--- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/response/NuageVlanIpRangeResponse.java ---
@@ -0,0 +1,38 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.response;
+
+import com.cloud.api.commands.VspConstants;
+import com.cloud.dc.Vlan;
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+import org.apache.cloudstack.api.EntityReference;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+
+@EntityReference(value = Vlan.class)
+public class NuageVlanIpRangeResponse extends VlanIpRangeResponse {
--- End diff --
We are not just communicating success/failure, but extending VlanIpRangeResponse along with a boolean flag to specify if the listed vlan ip ranges are underlay enabled (or) disabled in Nuage VSP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
<b>Trillian test result (tid-423)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27940 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1580-t423-kvm-centos7.zip
Test completed. 49 look ok, 0 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_vpc_site2site_vpn | Success | 160.12 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 61.09 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 245.94 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 270.39 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 582.17 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 533.14 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1279.01 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 599.95 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 767.31 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1315.35 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.67 | test_volumes.py
test_08_resize_volume | Success | 15.44 | test_volumes.py
test_07_resize_fail | Success | 20.47 | test_volumes.py
test_06_download_detached_volume | Success | 15.32 | test_volumes.py
test_05_detach_volume | Success | 100.28 | test_volumes.py
test_04_delete_attached_volume | Success | 10.20 | test_volumes.py
test_03_download_attached_volume | Success | 15.29 | test_volumes.py
test_02_attach_volume | Success | 75.43 | test_volumes.py
test_01_create_volume | Success | 652.46 | test_volumes.py
test_deploy_vm_multiple | Success | 329.03 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.75 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 36.07 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.85 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.90 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.36 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 151.12 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.28 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.21 | test_templates.py
test_01_create_template | Success | 60.75 | test_templates.py
test_10_destroy_cpvm | Success | 162.01 | test_ssvm.py
test_09_destroy_ssvm | Success | 193.88 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.63 | test_ssvm.py
test_07_reboot_ssvm | Success | 134.39 | test_ssvm.py
test_06_stop_cpvm | Success | 131.99 | test_ssvm.py
test_05_stop_ssvm | Success | 164.45 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 4.76 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.15 | test_snapshots.py
test_04_change_offering_small | Success | 205.18 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.06 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.21 | test_secondary_storage.py
test_09_reboot_router | Success | 35.31 | test_routers.py
test_08_start_router | Success | 40.38 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py
test_06_router_advanced | Success | 0.08 | test_routers.py
test_05_router_basic | Success | 0.05 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.70 | test_routers.py
test_03_restart_network_cleanup | Success | 70.62 | test_routers.py
test_02_router_internal_adv | Success | 0.93 | test_routers.py
test_01_router_internal_basic | Success | 0.51 | test_routers.py
test_router_dns_guestipquery | Success | 82.82 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.08 | test_router_dns.py
test_router_dhcphosts | Success | 271.58 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.09 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 171.20 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.07 | test_regions.py
test_create_pvlan_network | Success | 5.26 | test_pvlan.py
test_dedicatePublicIpRange | Success | 1.32 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 613.38 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 607.66 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 488.39 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 113.40 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 36.04 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 10.21 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.54 | test_portable_publicip.py
test_isolate_network_password_server | Success | 89.32 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.16 | test_over_provisioning.py
test_oobm_zchange_password | Success | 21.02 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.52 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.51 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 10.51 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.51 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 62.21 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.17 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 0.19 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.09 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.10 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 29.61 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.34 | test_non_contigiousvlan.py
test_01_nic | Success | 500.70 | test_nic.py
test_releaseIP | Success | 259.01 | test_network.py
test_reboot_router | Success | 460.08 | test_network.py
test_public_ip_user_account | Success | 10.41 | test_network.py
test_public_ip_admin_account | Success | 40.25 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 67.06 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.80 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 121.39 | test_network.py
test_delete_account | Success | 324.26 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.69 | test_network.py
test_01_port_fwd_on_src_nat | Success | 108.86 | test_network.py
test_nic_secondaryip_add_remove | Success | 198.45 | test_multipleips_per_nic.py
login_test_saml_user | Success | 24.70 | test_login.py
test_assign_and_removal_lb | Success | 135.63 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.20 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 217.93 | test_loadbalance.py
test_03_list_snapshots | Success | 0.08 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.07 | test_iso.py
test_04_extract_Iso | Success | 5.67 | test_iso.py
test_03_delete_iso | Success | 95.13 | test_iso.py
test_02_edit_iso | Success | 0.05 | test_iso.py
test_01_create_iso | Success | 21.92 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 345.19 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 243.64 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 723.79 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 485.79 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.35 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 7.08 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 7.26 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 6.94 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 6.84 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 6.91 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 6.90 | test_dynamicroles.py
test_role_lifecycle_update | Success | 12.03 | test_dynamicroles.py
test_role_lifecycle_list | Success | 6.88 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 12.02 | test_dynamicroles.py
test_role_lifecycle_create | Success | 7.33 | test_dynamicroles.py
test_role_inuse_deletion | Success | 6.80 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 9.06 | test_dynamicroles.py
test_role_account_acls | Success | 9.43 | test_dynamicroles.py
test_default_role_deletion | Success | 6.87 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.08 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.11 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 66.04 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 20.68 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 65.73 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.51 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 111.12 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.86 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 7.05 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 268.78 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 253.63 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 56.00 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd Here are the latest test results of the added Marvin tests that test the changes in this PR.
1) Marvin test run:
nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_static_nat.py
Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Nuage Underlay (underlay networking) enabled Public ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Static ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for Isolated network by ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for VPC network by ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with different Egress ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM NIC operations by ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM migration by ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with network restarts by ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 10 tests in 16073.682s
OK
Test results:
[results.txt](https://github.com/apache/cloudstack/files/612037/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/612038/runinfo.txt)
2) Marvin test run:
nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_source_nat.py
Test Nuage VSP Isolated networks with different combinations of ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Source ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for Isolated network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality for VPC network by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with different Egress ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with VM NIC operations by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with VM migration by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
Test Nuage VSP Source NAT functionality with network restarts by ... SKIP: Configured Nuage VSP SDN platform infrastructure does not support underlay networking: skipping test
----------------------------------------------------------------------
Ran 8 tests in 1658.814s
OK (SKIP=6)
Test results:
[results.txt](https://github.com/apache/cloudstack/files/612040/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/612041/runinfo.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd @jburwell Thank you for reviewing and helping us merge this PR, much appreciated !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@bvbharatk IMHO, above Marvin test failure is not related to the code on this PR. Let me know, if you want us to do any actions from our side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py
CloudStack$
Validations:
1) Nuage VSP underlay infra.
Marvin test run:
nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp
Test user data and password reset functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_UserDataPasswordReset | Status : SUCCESS ===
ok
Test Nuage VSP Isolated networks with different combinations of Source NAT service providers ... === TestName: test_01_nuage_SourceNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Source NAT service providers ... === TestName: test_02_nuage_SourceNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_03_nuage_SourceNAT_isolated_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_04_nuage_SourceNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_05_nuage_SourceNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_06_nuage_SourceNAT_vm_nic_operations_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_07_nuage_SourceNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Source NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_08_nuage_SourceNAT_network_restarts_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Public IP Range creation and deletion ... === TestName: test_01_nuage_StaticNAT_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Nuage Underlay (underlay networking) enabled Public IP Range creation and deletion ... === TestName: test_02_nuage_StaticNAT_underlay_public_ip_range | Status : SUCCESS ===
ok
Test Nuage VSP Isolated networks with different combinations of Static NAT service providers ... === TestName: test_03_nuage_StaticNAT_isolated_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC networks with different combinations of Static NAT service providers ... === TestName: test_04_nuage_StaticNAT_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for Isolated network by performing (wget) traffic tests to the ... === TestName: test_05_nuage_StaticNAT_isolated_networks_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality for VPC network by performing (wget) traffic tests to the Internet ... === TestName: test_06_nuage_StaticNAT_vpc_network_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with different Egress Firewall/Network ACL rules by performing (wget) ... === TestName: test_07_nuage_StaticNAT_acl_rules_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM NIC operations by performing (wget) traffic tests to the ... === TestName: test_08_nuage_StaticNAT_vm_nic_operations_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with VM migration by performing (wget) traffic tests to the Internet ... === TestName: test_09_nuage_StaticNAT_vm_migration_traffic | Status : SUCCESS ===
ok
Test Nuage VSP Static NAT functionality with network restarts by performing (wget) traffic tests to the ... === TestName: test_10_nuage_StaticNAT_network_restarts_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Offering with different combinations of LB service providers ... === TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS ===
ok
Test Nuage VSP VPC Network Offering with and without Internal LB service ... === TestName: test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS ===
ok
Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with different combinations of Internal LB rules ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality by performing (wget) traffic tests within a VPC ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with different LB algorithms by performing (wget) traffic tests ... === TestName: test_06_nuage_internallb_algorithms_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with restarts of VPC network components by performing (wget) ... === TestName: test_07_nuage_internallb_vpc_network_restarts_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with InternalLbVm appliance operations by performing (wget) ... === TestName: test_08_nuage_internallb_appliance_operations_traffic | Status : SUCCESS ===
ok
Test basic VPC Network functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS ===
ok
Test basic VPC Network functionality with Nuage VSP SDN plugin on multiple zones ... SKIP: There is only one Zone configured: skipping test
Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS ===
ok
Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName: test_nuage_vsp_device | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 31 tests in 28811.997s
OK (SKIP=1)
Test run logs:
[results.txt](https://github.com/apache/cloudstack/files/343587/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/343588/runinfo.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@jburwell @rhtyd I have re-based this PR with latest master, and we now only have two commits (1 dev + 1 test).
Jenkins and Travis are green now, you can now kick off regression tests on this PR via blueorangutan.
Meanwhile, we are re-running our local regression tests on the latest build.
Let me know, if you need anything from our side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by nlivens <gi...@git.apache.org>.
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1580
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin
Support for underlay features (Source & Static NAT to underlay) with Nuage VSP SDN Plugin including Marvin test coverage for corresponding Source & Static NAT features on master. Moreover, our Marvin tests are written in such a way that they can validate our supported feature set with both Nuage VSP SDN platform's overlay and underlay infra.
PR contents:
1) Support for Source NAT to underlay feature on master with Nuage VSP SDN Plugin.
2) Support for Static NAT to underlay feature on master with Nuage VSP SDN Plugin.
3) Marvin test coverage for Source & Static NAT to underlay on master with Nuage VSP SDN Plugin.
4) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
5) PEP8 & PyFlakes compliance with our Marvin test code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack nuage_vsp_pat_fip2ul
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1580.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1580
----
commit e5fd206e7e090121798c80745df4629f890e3234
Author: Eric Waegeman <er...@nuagenetworks.net>
Date: 2016-05-26T09:37:52Z
CLOUDSTACK-9401 : Support for Internal DNS in Nuage VSP plugin
commit ec7b6a5f887555e513b1d1d9c5e469eb079d721a
Author: Prashanth Manthena <pr...@alcatel-lucent.com>
Date: 2016-05-26T10:48:02Z
CLOUDSTACK-9402 : Marvin tests for Source NAT and Static NAT including PAT/FIP2UL features with NuageVsp
commit be8ae9376664925255595a50f5c4574c4abb7179
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-06-15T09:04:21Z
CLOUDSTACK-9402 : Support for underlay features (Source & Static NAT to underlay) in Nuage VSP plugin
commit a2e1999bbacf3e00570bd51492b05cda8ca81c7d
Author: Rahul Singal <ra...@nuagenetworks.net>
Date: 2016-07-01T13:22:50Z
CLOUDSTACK-9401 : Marvin tests for Internal DNS verification with NuageVsp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@remibergsma As a common team practice, we just happened to agree upon with this line length :). Agree, we should make our Marvin code truly PEP8 compliant as you suggested, and update our Marvin code accordingly.
I ran all our Marvin tests with this PR as it involves Nuage VSP support for underlay networking besides our default overlay networking. Moreover, we perform quite a few VM deployments (reboots, migrations, expunges, etc.) and traffic tests (e.g. SSH into VM and then wget from the Internet) in these tests. Finally, the CentOS guest VM template that we use for our internal regressions takes a bit longer to start/stop guest VMs (rich feature set and programmes).
Here are some metrics:
VM deployements: 63
Isolated network creations: 57
SSH into VMs (reconnects) = 82
Note: Unless required, we don't always run all of our Marvin tests in a single Marvin run.
Anyhow, we actively use nosetests features such as tags/attributes to run subset of these tests in the following scenarios:
1) simulator tests (required hardware=false)
2) feature specific tests
3) basic (smoke) tests
4) E2E (traffic) tests
Note: Once we have considerable number of tests in our plugins/nuagevsp directory, we are also thinking about creating sub-directories as well (e.g. component, smoke, etc.).
Let me know, your thoughts on this, and if you have any other questions for me.
Thank you for your valuable review and suggestions !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89277508
--- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/response/NuageVlanIpRangeResponse.java ---
@@ -0,0 +1,38 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.response;
+
+import com.cloud.api.commands.VspConstants;
+import com.cloud.dc.Vlan;
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+import org.apache.cloudstack.api.EntityReference;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+
+@EntityReference(value = Vlan.class)
+public class NuageVlanIpRangeResponse extends VlanIpRangeResponse {
--- End diff --
If you only need to communicate success/failure, you an use SuccessResponse instead of reintroducing a new class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---