You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/08/26 09:41:55 UTC
[GitHub] spark pull request #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend...
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/22235
[SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names in setup.py
## What changes were proposed in this pull request?
**Before:**
```bash
$ python -m flake8 . --count --select=E9,F82 --show-source --statistics
./setup.py:37:11: F821 undefined name '__version__'
VERSION = __version__
^
1 F821 undefined name '__version__'
1
```
**After:**
```bash
$ python -m flake8 . --count --select=E9,F82 --show-source --statistics
0
```
## How was this patch tested?
Manually tested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-23698
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22235
----
commit f63bd3d8af0fb1c65fd5f32c8c052caa69a51fff
Author: hyukjinkwon <gu...@...>
Date: 2018-08-26T09:40:16Z
Resolve undefiend names in setup.py
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22235
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2555/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22235
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95260/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22235
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22235
**[Test build #95260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95260/testReport)** for PR 22235 at commit [`f63bd3d`](https://github.com/apache/spark/commit/f63bd3d8af0fb1c65fd5f32c8c052caa69a51fff).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22235
**[Test build #95260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95260/testReport)** for PR 22235 at commit [`f63bd3d`](https://github.com/apache/spark/commit/f63bd3d8af0fb1c65fd5f32c8c052caa69a51fff).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22235
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org