You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2025/01/07 11:47:13 UTC

[PR] [Improve] MaxComputeSink support create partition in savemode [seatunnel]

Hisoka-X opened a new pull request, #8474:
URL: https://github.com/apache/seatunnel/pull/8474

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   -->
   
   ### Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   
   
   ### How was this patch tested?
   
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
   -->
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   * [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] MaxComputeSink support create partition in savemode [seatunnel]

Posted by "W-dragan (via GitHub)" <gi...@apache.org>.
W-dragan commented on code in PR #8474:
URL: https://github.com/apache/seatunnel/pull/8474#discussion_r1912804700


##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/sink/MaxComputeSaveModeHandler.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.maxcompute.sink;
+
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.sink.DataSaveMode;
+import org.apache.seatunnel.api.sink.DefaultSaveModeHandler;
+import org.apache.seatunnel.api.sink.SchemaSaveMode;
+import org.apache.seatunnel.api.table.catalog.Catalog;
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.connectors.seatunnel.maxcompute.catalog.MaxComputeCatalog;
+
+import org.apache.commons.lang3.StringUtils;
+
+import com.aliyun.odps.PartitionSpec;
+
+import static org.apache.seatunnel.connectors.seatunnel.maxcompute.config.MaxcomputeConfig.PARTITION_SPEC;
+
+public class MaxComputeSaveModeHandler extends DefaultSaveModeHandler {
+
+    private final ReadonlyConfig readonlyConfig;
+
+    public MaxComputeSaveModeHandler(
+            SchemaSaveMode schemaSaveMode,
+            DataSaveMode dataSaveMode,
+            Catalog catalog,
+            CatalogTable catalogTable,
+            String customSql,
+            ReadonlyConfig readonlyConfig) {
+        super(schemaSaveMode, dataSaveMode, catalog, catalogTable, customSql);
+        this.readonlyConfig = readonlyConfig;
+    }
+
+    @Override
+    protected void createSchemaWhenNotExist() {
+        super.createSchemaWhenNotExist();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(
+                            tablePath, new PartitionSpec(readonlyConfig.get(PARTITION_SPEC)));
+        }
+    }
+
+    @Override
+    protected void recreateSchema() {
+        super.recreateSchema();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(

Review Comment:
   My understanding of 'recreate schema' is to delete a table or partition, and then recreate the table/partition. In the context of maxcompute, it is equivalent to overwrite=true. 
   
   Otherwise, the method you wrote in MaxCompute Catalog will not be called anywhere. Or is this method written in advance for future expansion?
   
   https://github.com/apache/seatunnel/blob/df1420170f662ac04964664f9d5c9d426fdeddad/seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/catalog/MaxComputeCatalog.java#L256



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] MaxComputeSink support create partition in savemode [seatunnel]

Posted by "W-dragan (via GitHub)" <gi...@apache.org>.
W-dragan commented on code in PR #8474:
URL: https://github.com/apache/seatunnel/pull/8474#discussion_r1912792567


##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/sink/MaxComputeSaveModeHandler.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.maxcompute.sink;
+
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.sink.DataSaveMode;
+import org.apache.seatunnel.api.sink.DefaultSaveModeHandler;
+import org.apache.seatunnel.api.sink.SchemaSaveMode;
+import org.apache.seatunnel.api.table.catalog.Catalog;
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.connectors.seatunnel.maxcompute.catalog.MaxComputeCatalog;
+
+import org.apache.commons.lang3.StringUtils;
+
+import com.aliyun.odps.PartitionSpec;
+
+import static org.apache.seatunnel.connectors.seatunnel.maxcompute.config.MaxcomputeConfig.PARTITION_SPEC;
+
+public class MaxComputeSaveModeHandler extends DefaultSaveModeHandler {
+
+    private final ReadonlyConfig readonlyConfig;
+
+    public MaxComputeSaveModeHandler(
+            SchemaSaveMode schemaSaveMode,
+            DataSaveMode dataSaveMode,
+            Catalog catalog,
+            CatalogTable catalogTable,
+            String customSql,
+            ReadonlyConfig readonlyConfig) {
+        super(schemaSaveMode, dataSaveMode, catalog, catalogTable, customSql);
+        this.readonlyConfig = readonlyConfig;
+    }
+
+    @Override
+    protected void createSchemaWhenNotExist() {
+        super.createSchemaWhenNotExist();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(
+                            tablePath, new PartitionSpec(readonlyConfig.get(PARTITION_SPEC)));
+        }
+    }
+
+    @Override
+    protected void recreateSchema() {
+        super.recreateSchema();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(

Review Comment:
   I think the code here may be copied and pasted from the previous method, so it should be written like this
   ((MaxComputeCatalog) catalog)
   .truncatePartition(
   tablePath, new PartitionSpec(readonlyConfig.get(PARTITION_SPEC)));



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] MaxComputeSink support create partition in savemode [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #8474:
URL: https://github.com/apache/seatunnel/pull/8474#discussion_r1912807607


##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/sink/MaxComputeSaveModeHandler.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.maxcompute.sink;
+
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.sink.DataSaveMode;
+import org.apache.seatunnel.api.sink.DefaultSaveModeHandler;
+import org.apache.seatunnel.api.sink.SchemaSaveMode;
+import org.apache.seatunnel.api.table.catalog.Catalog;
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.connectors.seatunnel.maxcompute.catalog.MaxComputeCatalog;
+
+import org.apache.commons.lang3.StringUtils;
+
+import com.aliyun.odps.PartitionSpec;
+
+import static org.apache.seatunnel.connectors.seatunnel.maxcompute.config.MaxcomputeConfig.PARTITION_SPEC;
+
+public class MaxComputeSaveModeHandler extends DefaultSaveModeHandler {
+
+    private final ReadonlyConfig readonlyConfig;
+
+    public MaxComputeSaveModeHandler(
+            SchemaSaveMode schemaSaveMode,
+            DataSaveMode dataSaveMode,
+            Catalog catalog,
+            CatalogTable catalogTable,
+            String customSql,
+            ReadonlyConfig readonlyConfig) {
+        super(schemaSaveMode, dataSaveMode, catalog, catalogTable, customSql);
+        this.readonlyConfig = readonlyConfig;
+    }
+
+    @Override
+    protected void createSchemaWhenNotExist() {
+        super.createSchemaWhenNotExist();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(
+                            tablePath, new PartitionSpec(readonlyConfig.get(PARTITION_SPEC)));
+        }
+    }
+
+    @Override
+    protected void recreateSchema() {
+        super.recreateSchema();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(

Review Comment:
   it will be invoke in https://github.com/apache/seatunnel/blob/df1420170f662ac04964664f9d5c9d426fdeddad/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/DefaultSaveModeHandler.java#L217



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] MaxComputeSink support create partition in savemode [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #8474:
URL: https://github.com/apache/seatunnel/pull/8474#issuecomment-2582113166

   ![image](https://github.com/user-attachments/assets/8caf4403-68cc-4279-9b64-6954cf4cb378)
   ![image](https://github.com/user-attachments/assets/39f29fc7-4011-40c4-9256-5f5900c20aa5)
   ![image](https://github.com/user-attachments/assets/73f32799-0f56-4eaf-bc23-bf333730e7be)
   ![image](https://github.com/user-attachments/assets/7efa8e18-d942-4cfc-a85a-7994e4869a51)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] MaxComputeSink support create partition in savemode [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #8474:
URL: https://github.com/apache/seatunnel/pull/8474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] MaxComputeSink support create partition in savemode [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #8474:
URL: https://github.com/apache/seatunnel/pull/8474#discussion_r1912807607


##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/sink/MaxComputeSaveModeHandler.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.maxcompute.sink;
+
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.sink.DataSaveMode;
+import org.apache.seatunnel.api.sink.DefaultSaveModeHandler;
+import org.apache.seatunnel.api.sink.SchemaSaveMode;
+import org.apache.seatunnel.api.table.catalog.Catalog;
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.connectors.seatunnel.maxcompute.catalog.MaxComputeCatalog;
+
+import org.apache.commons.lang3.StringUtils;
+
+import com.aliyun.odps.PartitionSpec;
+
+import static org.apache.seatunnel.connectors.seatunnel.maxcompute.config.MaxcomputeConfig.PARTITION_SPEC;
+
+public class MaxComputeSaveModeHandler extends DefaultSaveModeHandler {
+
+    private final ReadonlyConfig readonlyConfig;
+
+    public MaxComputeSaveModeHandler(
+            SchemaSaveMode schemaSaveMode,
+            DataSaveMode dataSaveMode,
+            Catalog catalog,
+            CatalogTable catalogTable,
+            String customSql,
+            ReadonlyConfig readonlyConfig) {
+        super(schemaSaveMode, dataSaveMode, catalog, catalogTable, customSql);
+        this.readonlyConfig = readonlyConfig;
+    }
+
+    @Override
+    protected void createSchemaWhenNotExist() {
+        super.createSchemaWhenNotExist();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(
+                            tablePath, new PartitionSpec(readonlyConfig.get(PARTITION_SPEC)));
+        }
+    }
+
+    @Override
+    protected void recreateSchema() {
+        super.recreateSchema();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(

Review Comment:
   it will be invoked in https://github.com/apache/seatunnel/blob/df1420170f662ac04964664f9d5c9d426fdeddad/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/DefaultSaveModeHandler.java#L217



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] MaxComputeSink support create partition in savemode [seatunnel]

Posted by "W-dragan (via GitHub)" <gi...@apache.org>.
W-dragan commented on code in PR #8474:
URL: https://github.com/apache/seatunnel/pull/8474#discussion_r1912821087


##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/sink/MaxComputeSaveModeHandler.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.maxcompute.sink;
+
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.sink.DataSaveMode;
+import org.apache.seatunnel.api.sink.DefaultSaveModeHandler;
+import org.apache.seatunnel.api.sink.SchemaSaveMode;
+import org.apache.seatunnel.api.table.catalog.Catalog;
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.connectors.seatunnel.maxcompute.catalog.MaxComputeCatalog;
+
+import org.apache.commons.lang3.StringUtils;
+
+import com.aliyun.odps.PartitionSpec;
+
+import static org.apache.seatunnel.connectors.seatunnel.maxcompute.config.MaxcomputeConfig.PARTITION_SPEC;
+
+public class MaxComputeSaveModeHandler extends DefaultSaveModeHandler {
+
+    private final ReadonlyConfig readonlyConfig;
+
+    public MaxComputeSaveModeHandler(
+            SchemaSaveMode schemaSaveMode,
+            DataSaveMode dataSaveMode,
+            Catalog catalog,
+            CatalogTable catalogTable,
+            String customSql,
+            ReadonlyConfig readonlyConfig) {
+        super(schemaSaveMode, dataSaveMode, catalog, catalogTable, customSql);
+        this.readonlyConfig = readonlyConfig;
+    }
+
+    @Override
+    protected void createSchemaWhenNotExist() {
+        super.createSchemaWhenNotExist();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(
+                            tablePath, new PartitionSpec(readonlyConfig.get(PARTITION_SPEC)));
+        }
+    }
+
+    @Override
+    protected void recreateSchema() {
+        super.recreateSchema();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(

Review Comment:
   Understood, there is a deviation in my understanding. Thank you for your guidance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] MaxComputeSink support create partition in savemode [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #8474:
URL: https://github.com/apache/seatunnel/pull/8474#discussion_r1912795498


##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/sink/MaxComputeSaveModeHandler.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.maxcompute.sink;
+
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.sink.DataSaveMode;
+import org.apache.seatunnel.api.sink.DefaultSaveModeHandler;
+import org.apache.seatunnel.api.sink.SchemaSaveMode;
+import org.apache.seatunnel.api.table.catalog.Catalog;
+import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.connectors.seatunnel.maxcompute.catalog.MaxComputeCatalog;
+
+import org.apache.commons.lang3.StringUtils;
+
+import com.aliyun.odps.PartitionSpec;
+
+import static org.apache.seatunnel.connectors.seatunnel.maxcompute.config.MaxcomputeConfig.PARTITION_SPEC;
+
+public class MaxComputeSaveModeHandler extends DefaultSaveModeHandler {
+
+    private final ReadonlyConfig readonlyConfig;
+
+    public MaxComputeSaveModeHandler(
+            SchemaSaveMode schemaSaveMode,
+            DataSaveMode dataSaveMode,
+            Catalog catalog,
+            CatalogTable catalogTable,
+            String customSql,
+            ReadonlyConfig readonlyConfig) {
+        super(schemaSaveMode, dataSaveMode, catalog, catalogTable, customSql);
+        this.readonlyConfig = readonlyConfig;
+    }
+
+    @Override
+    protected void createSchemaWhenNotExist() {
+        super.createSchemaWhenNotExist();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(
+                            tablePath, new PartitionSpec(readonlyConfig.get(PARTITION_SPEC)));
+        }
+    }
+
+    @Override
+    protected void recreateSchema() {
+        super.recreateSchema();
+        if (StringUtils.isNotEmpty(readonlyConfig.get(PARTITION_SPEC))) {
+            ((MaxComputeCatalog) catalog)
+                    .createPartition(

Review Comment:
   Hi @W-dragan , after recreate schema, the old partition will be deleted too, so why we need truncate it not create it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org